draft/2019-09: exclusiveMinimum and exclusiveMaximum must be numbers

[saman]

In my workspace, if I put $schema to 2019-09, and set exclusiveMinimum and exclusiveMaximum with a boolean is not throwing any error.

Considering these two examples:

A JSON Schema based on draft-07

{
    "$id": "https://example.com/my-schema",
    "$schema": "https://json-schema.org/draft-07/schema",
    "properties": {
        "test": {
            "type": "number",
            "minimum": 0,
            "exclusiveMinimum": true,
            "maximum": 100,
            "exclusiveMaximum": true
        }
    }
}

And a JSON Schema based on lastest version draft 2019-09

{
    "$id": "https://example.com/my-schema",
    "$schema": "https://json-schema.org/draft/2019-09/schema",
    "properties": {
        "test": {
            "type": "number",
            "minimum": 0,
            "exclusiveMinimum": true,
            "maximum": 100,
            "exclusiveMaximum": true
        }
    }
}

The example with draft 2019-09 is going to be accepted, while the first example with draft-07 throws an error as expected:
Incorrect type. Expected "number".

As I can see in jsonParser.ts is going to accept both number and boolean on 2019-09 which is incorrect while It is showing an expected error on draft-09.
2019-09 draft specefication mention this:

6.2.3. exclusiveMaximum
The value of "exclusiveMaximum" MUST be number, representing an exclusive upper limit for a numeric instance.

6.2.5. exclusiveMinimum
The value of "exclusiveMinimum" MUST be number, representing an exclusive lower limit for a numeric instance.

[KapitanOczywisty]

@saman 2019-09 is not yet supported. Also this is not a problem with exclusiveMinimum, but with properties which is defined with new $recursiveRef property. https://github.com/json-schema-org/json-schema-spec/blob/2019-09/meta/applicator.json#L25

[Trias]

Not the OP, but is there any 2019-09 support planned?

[KapitanOczywisty]

Not the OP, but is there any 2019-09 support planned?

@aeschli ? :)

[aeschli]

We have microsoft/vscode#98724 as issue to support 2019-09.
It hasn't been requested many times yet, and don't know yet when I will able to tackle it. If anyone wants to help, that would be fantastic.

[KapitanOczywisty]

@aeschli I might implement some features, but specification is very unfriendly to non-native speakers.

Btw. shouldn't this be resolveErrors? There is code to warn about 2019-09, but there is no visible warning in vscode.

vscode-json-languageservice/src/services/jsonSchemaService.ts

Lines 401 to 402 in 76f4b43

	} else if (id === 'https://json-schema.org/draft/2019-09/schema') {
	schemaToResolve.errors.push(localize('json.schema.draft201909.notsupported', "Draft 2019-09 schemas are not yet fully supported."));

[Relequestual]

@aeschli I'm not sure any of the JSON Schema team can help with the actual implementation, but I can sure help with any clarifications if required!

It may be helpful to know there is already an implementation in js (https://github.com/hyperjump-io/json-schema-validator).

The test suite for 2019-09 is still not yet complete... but we're working on it...

[aeschli]

@KapitanOczywisty Good catch, fixed resolveErrors, now the error will show

[KapitanOczywisty]

@Relequestual $recursiveRef and $recursiveAnchor are the first to implement since they're breaking completely new schema.
Few questions:

1. $recursiveAnchor can be only in schema's root?
2. $recursiveRef always has value of #?
3. in absence of $recursiveAnchor (or false), is $recursiveRef equal to $ref?

[Relequestual]

@Relequestual $recursiveRef and $recursiveAnchor are the first to implement since they're breaking completely new schema.
Few questions:

1. `$recursiveAnchor` can be only in schema's root?

2. `$recursiveRef` always has value of `#`?

3. in absence of `$recursiveAnchor` (or false), is `$recursiveRef` equal to `$ref`?

Yes, Yes, and, Yes.

We recently release JSON Schema draft 2020-12. We've tweaked this to be more useful, but it may be a little harder to understand.

Come by the JSON Schema slack if you have more questions =]

[KapitanOczywisty]

I wonder If It wouldn't be better to use ajv instead writing another dedicated implementation. This extension is probably used by vscode internally, but ajv is pretty light and wouldn't be adding much overhead. @aeschli ?

[Relequestual]

It might be, although I assume this code gives a lot more features, such as auto-complete and highlights.
You may get better results out of using the core part (separate repo) from hyperjump, which is the first 2020-12 implementation.

[KapitanOczywisty]

Additional features you have to implement anyway, but might be easier when you're not concerned about schema formats. However validation for incomplete schema might be not handled by ajv, which is a problem.. Just forget that bad idea 😛

Back to topic: With 3x Yes, $recursiveRef should be easy to implement in existing structure, with minor changes. But again 2020-12 have $dynamicRef which seems not that easy, so probably $ref mechanics have to be overhauled which is beyond my capabilities atm.