Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to save: Canceled #15698

Closed
digitarald opened this issue May 18, 2024 · 6 comments · Fixed by microsoft/vscode#214036
Closed

Failed to save: Canceled #15698

digitarald opened this issue May 18, 2024 · 6 comments · Fixed by microsoft/vscode#214036
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@digitarald
Copy link

digitarald commented May 18, 2024

Type: Bug

I keep getting into that mode as I work on my notebook.

Closing and re-opening the file didn't help.

image

Maybe related logs from DevTools

TRACE [History stack global-default]: index: 38, navigating: false
- group: 0, editor: file:///Users/digitarald/Developer/msft-build-copilot-demo/Flight_Data_Analysis.ipynb, selection: W0sZmlsZQ==
- group: 0, editor: file:///Users/digitarald/Developer/msft-build-copilot-demo/Flight_Data_Analysis.ipynb, selection: W3sZmlsZQ==
- group: 0, editor: vscode-userdata:/Users/digitarald/Library/Application%20Support/Code%20-%20Insiders/User/settings.json, selection: line: 76-76, col:  7-7
- group: 0, editor: file:///Users/digitarald/Developer/msft-build-copilot-demo/Flight_Data_Analysis.ipynb, selection: W3sZmlsZQ==
- group: 0, editor: vscode-userdata:/Users/digitarald/Library/Application%20Support/Code%20-%20Insiders/User/settings.json, selection: line: 77-80, col:  5-6
- group: 0, editor: file:///Users/digitarald/Developer/msft-build-copilot-demo/Flight_Data_Analysis.ipynb, selection: W3sZmlsZQ==
- group: 0, editor: file:///Users/digitarald/Developer/msft-build-copilot-demo/Flight_Data_Analysis.ipynb, selection: W0sZmlsZQ==
- group: 0, editor: file:///Users/digitarald/Developer/msft-build-copilot-demo/Flight_Data_Analysis.ipynb, selection: W3sZmlsZQ==
- group: 0, editor: file:///Users/digitarald/Developer/msft-build-copilot-demo/Flight_Data_Analysis.ipynb, selection: W2sZmlsZQ==
- group: 0, editor: file:///Users/digitarald/Developer/msft-build-copilot-demo/Flight_Data_Analysis.ipynb, selection: W4sZmlsZQ==
- group: 0, editor: file:///Users/digitarald/Developer/msft-build-copilot-demo/Flight_Data_Analysis.ipynb, selection: W6sZmlsZQ==
- group: 0, editor: file:///Users/digitarald/Developer/msft-build-copilot-demo/Flight_Data_Analysis.ipynb, selection: X11sZmlsZQ==
- group: 0, editor: file:///Users/digitarald/Developer/msft-build-copilot-demo/Flight_Data_Analysis.ipynb, selection: W6sZmlsZQ==
- group: 0, editor: file:///Users/digitarald/Developer/msft-build-copilot-demo/Flight_Data_Analysis.ipynb, selection: X11sZmlsZQ==
- group: 0, editor: file:///Users/digitarald/Developer/msft-build-copilot-demo/Flight_Data_Analysis.ipynb, selection: X13sZmlsZQ==
- group: 0, editor: file:///Users/digitarald/Developer/msft-build-copilot-demo/Flight_Data_Analysis.ipynb, selection: X11sZmlsZQ==
- group: 0, editor: file:///Users/digitarald/Developer/msft-build-copilot-demo/Flight_Data_Analysis.ipynb, selection: X13sZmlsZQ==
- group: 0, editor: file:///Users/digitarald/Developer/msft-build-copilot-demo/Flight_Data_Analysis.ipynb, selection: W2sZmlsZQ==
- group: 0, editor: file:///Users/digitarald/Developer/msft-build-copilot-demo/Flight_Data_Analysis.ipynb, selection: W0sZmlsZQ==
- group: 0, editor: file:///Users/digitarald/Developer/msft-build-copilot-demo/Flight_Data_Analysis.ipynb, selection: W1sZmlsZQ==
- group: 0, editor: file:///Users/digitarald/Developer/msft-build-copilot-demo/Flight_Data_Analysis.ipynb, selection: W2sZmlsZQ==
- group: 0, editor: file:///Users/digitarald/Developer/msft-build-copilot-demo/Flight_Data_Analysis.ipynb, selection: W1sZmlsZQ==
- group: 0, editor: file:///Users/digitarald/Developer/msft-build-copilot-demo/Flight_Data_Analysis.ipynb, selection: W0sZmlsZQ==
- group: 0, editor: file:///Users/digitarald/Developer/msft-build-copilot-demo/Flight_Data_Analysis.ipynb, selection: W1sZmlsZQ==
- group: 0, editor: file:///Users/digitarald/Developer/msft-build-copilot-demo/Flight_Data_Analysis.ipynb, selection: W2sZmlsZQ==
- group: 0, editor: file:///Users/digitarald/Developer/msft-build-copilot-demo/Flight_Data_Analysis.py, selection: line: 9-9, col:  1-1
- group: 0, editor: file:///Users/digitarald/Developer/msft-build-copilot-demo/Flight_Data_Analysis.ipynb, selection: W2sZmlsZQ==
- group: 0, editor: file:///Users/digitarald/.zshrc, selection: line: 9-9, col:  42-57
- group: 0, editor: file:///Users/digitarald/.zsh_plugins.txt, selection: line: 1-1, col:  19-19
- group: 0, editor: file:///Users/digitarald/.zshrc, selection: line: 6-6, col:  25-25
- group: 0, editor: file:///Users/digitarald/.zsh_plugins.txt, selection: line: 2-2, col:  22-22
- group: 0, editor: file:///Users/digitarald/.zshrc, selection: line: 13-13, col:  1-1
- group: 0, editor: file:///Users/digitarald/.zsh_plugins.txt, selection: line: 2-2, col:  22-22
- group: 0, editor: file:///Users/digitarald/Developer/msft-build-copilot-demo/Flight_Data_Analysis.ipynb, selection: W2sZmlsZQ==
- group: 0, editor: file:///Users/digitarald/Developer/msft-build-copilot-demo/Flight_Data_Analysis.ipynb, selection: W1sZmlsZQ==
- group: 0, editor: file:///Users/digitarald/Developer/msft-build-copilot-demo/Flight_Data_Analysis.py, selection: line: 9-9, col:  1-1
- group: 0, editor: file:///Users/digitarald/Developer/msft-build-copilot-demo/Flight_Data_Analysis.ipynb, selection: W1sZmlsZQ==
- group: 0, editor: file:///Users/digitarald/Developer/msft-build-copilot-demo/Flight_Data_Analysis.py, selection: line: 9-9, col:  1-1
- group: 0, editor: file:///Users/digitarald/Developer/msft-build-copilot-demo/Flight_Data_Analysis.ipynb, selection: W1sZmlsZQ==
			
log.ts:399 TRACE [stored file working copy] doSave(739) - before write() file:///Users/digitarald/Developer/msft-build-copilot-demo/Flight_Data_Analysis.ipynb notebook/jupyter-notebook
log.ts:439   ERR [stored file working copy] handleSaveError(739) - exit - resulted in a save error: Canceled: Canceled file:///Users/digitarald/Developer/msft-build-copilot-demo/Flight_Data_Analysis.ipynb notebook/jupyter-notebook
notificationsAlerts.ts:42 Failed to save 'Flight_Data_Analysis.ipynb': Canceled

Extension version: 2024.4.2024042601
VS Code version: Code - Insiders 1.90.0-insider (f209ce35ef894bd32c12057724e8d1f1139c433f, 2024-05-17T17:53:51.447Z)
OS version: Darwin x64 23.4.0
Modes:

System Info
Item Value
CPUs Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz (16 x 2400)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
webgpu: enabled
Load (avg) 4, 4, 3
Memory (System) 64.00GB (0.05GB free)
Process Argv --log trace --crash-reporter-id 4cf0a6f0-aaf8-4da3-9b2b-81f6c639c12b
Screen Reader no
VM 0%
A/B Experiments
vsliv368cf:30146710
vspor879:30202332
vspor708:30202333
vspor363:30204092
tftest:31042121
vscod805:30301674
vsaa593:30376534
py29gd2263:31024238
vscaac:30438845
c4g48928:30535728
a9j8j154:30646983
962ge761:30841072
pythongtdpath:30726887
welcomedialogc:30812479
pythonidxpt:30768918
pythonnoceb:30776497
asynctok:30898717
dsvsc013:30777762
dsvsc014:30777825
dsvsc015:30821418
pythontestfixt:30866404
pythonregdiag2:30926734
pythonmypyd1:30859725
pythoncet0:30859736
h48ei257:31000450
pythontbext0:30879054
accentitlementst:30870582
dsvsc016:30879898
dsvsc017:30880771
dsvsc018:30880772
cppperfnew:30980852
pythonait:30973460
showvideot:31016890
chatpanelt:31014475
f3je6385:31013174
a69g1124:31018687
dvdeprecation:31040973
pythonprt:31036556
dwnewjupyter:31046869
impr_priority:31052045
26j00206:31048877

@amunger
Copy link
Contributor

amunger commented May 24, 2024

Some relevant trace logs from a repro

2024-05-24 08:44:14.770 [trace] [stored file working copy] onModelContentChanged() - enter file:///c%3A/src/test/3/dataframeOps.ipynb notebook/jupyter-notebook
2024-05-24 08:44:14.770 [trace] [stored file working copy] onModelContentChanged() - new versionId 2 file:///c%3A/src/test/3/dataframeOps.ipynb notebook/jupyter-notebook
2024-05-24 08:44:14.770 [trace] [stored file working copy] onModelContentChanged() - model content changed and marked as dirty file:///c%3A/src/test/3/dataframeOps.ipynb notebook/jupyter-notebook
2024-05-24 08:44:14.771 [trace] [backup tracker] scheduling backup file:///c%3A/src/test/3/dataframeOps.ipynb notebook/jupyter-notebook
2024-05-24 08:44:14.771 [trace] [editor auto save] scheduling auto save after 1000ms file:///c%3A/src/test/3/dataframeOps.ipynb notebook/jupyter-notebook
2024-05-24 08:44:14.773 [trace] [backup tracker] clearing pending backup creation file:///c%3A/src/test/3/dataframeOps.ipynb notebook/jupyter-notebook
2024-05-24 08:44:14.774 [trace] [backup tracker] scheduling backup file:///c%3A/src/test/3/dataframeOps.ipynb notebook/jupyter-notebook
2024-05-24 08:44:14.774 [trace] [editor auto save] clearing pending auto save file:///c%3A/src/test/3/dataframeOps.ipynb notebook/jupyter-notebook
2024-05-24 08:44:14.774 [trace] [editor auto save] scheduling auto save after 1000ms file:///c%3A/src/test/3/dataframeOps.ipynb notebook/jupyter-notebook
2024-05-24 08:44:15.779 [trace] [editor auto save] clearing pending auto save file:///c%3A/src/test/3/dataframeOps.ipynb notebook/jupyter-notebook
2024-05-24 08:44:15.780 [trace] [editor auto save] running auto save file:///c%3A/src/test/3/dataframeOps.ipynb notebook/jupyter-notebook
2024-05-24 08:44:15.780 [trace] [stored file working copy] save() - enter file:///c%3A/src/test/3/dataframeOps.ipynb notebook/jupyter-notebook
2024-05-24 08:44:15.780 [trace] [stored file working copy] doSave(2) - enter with versionId 2 file:///c%3A/src/test/3/dataframeOps.ipynb notebook/jupyter-notebook
2024-05-24 08:44:16.116 [debug] User data changed
2024-05-24 08:44:16.481 [debug] User data changed
2024-05-24 08:44:17.547 [warning] Aborted onWillSaveNotebookDocument-event after 1750ms
2024-05-24 08:44:17.547 [trace] [stored file working copy] doSave(2) - before write() file:///c%3A/src/test/3/dataframeOps.ipynb notebook/jupyter-notebook
2024-05-24 08:44:17.548 [error] [stored file working copy] handleSaveError(2) - exit - resulted in a save error: Canceled: Canceled file:///c%3A/src/test/3/dataframeOps.ipynb notebook/jupyter-notebook
2024-05-24 08:44:17.551 [trace] [stored file working copy] save() - exit file:///c%3A/src/test/3/dataframeOps.ipynb notebook/jupyter-notebook
2024-05-24 08:44:18.432 [info] Extension host (LocalProcess pid: 12180) is unresponsive.
2024-05-24 08:44:19.023 [info] UNRESPONSIVE extension host: starting to profile NOW
2024-05-24 08:44:19.103 [trace] CommandService#executeCommand _setContext
2024-05-24 08:44:19.120 [info] Extension host (LocalProcess pid: 12180) is responsive.
2024-05-24 08:44:19.120 [info] UNRESPONSIVE extension host: received responsive event and cancelling profiling session
2024-05-24 08:44:19.275 [warning] UNRESPONSIVE extension host: 'ms-python.python' took 9.175040991439579% of 9.121ms, saved PROFILE here: 'file:///c%3A/Users/aamunger/AppData/Local/Temp/exthost-060fce.cpuprofile'

@amunger
Copy link
Contributor

amunger commented May 24, 2024

The canceled error should be taken care of by the PR, so please update to the latest and see if this still repro's. If so, the trace logs from 'Window' and Extension host would be very helpful.
And let me know what the notebook.experimental.remoteSave setting was set to (on by default in insiders)

@amunger amunger closed this as completed May 24, 2024
@amunger amunger added the bug Issue identified by VS Code Team member as probable bug label May 28, 2024
@amunger amunger added this to the May 2024 milestone May 28, 2024
@amunger amunger added the author-verification-requested Issues potentially verifiable by issue author label May 28, 2024
@connor4312
Copy link
Member

Are there steps for this?

@connor4312 connor4312 added the verification-steps-needed Steps to verify are needed for verification label May 30, 2024
@amunger
Copy link
Contributor

amunger commented May 30, 2024

@digitarald would be the best verifier here since I don't know of anyone else hitting this, but just reloading vscode with a notebook open and a jupyter kernel selected seemed to sporadically trigger the repro. As long as you don't see a save error

@amunger amunger removed the verification-steps-needed Steps to verify are needed for verification label May 30, 2024
@digitarald
Copy link
Author

Did my demo run-through a few more times and haven't hit this again.

@digitarald digitarald added verified Verification succeeded and removed author-verification-requested Issues potentially verifiable by issue author labels May 30, 2024
@amunger amunger removed the verified Verification succeeded label May 31, 2024
@amunger amunger reopened this May 31, 2024
@amunger
Copy link
Contributor

amunger commented May 31, 2024

found a repro:

  1. open a notebook
  2. Developer: restart extension host
  3. make a change and save

@amunger amunger modified the milestones: May 2024, June 2024 Jun 3, 2024
@rzhao271 rzhao271 modified the milestones: May 2024, June 2024 Jun 3, 2024
@rzhao271 rzhao271 added the verified Verification succeeded label Jun 26, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants