Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NativeEditor.ts and InteractiveWindow.ts could have their 'execution' logic split off #1606

Closed
Tracked by #6950
rchiodo opened this issue May 6, 2020 · 0 comments
Closed
Tracked by #6950

Comments

@rchiodo
Copy link
Contributor

rchiodo commented May 6, 2020

The 'execution' of a notebook is more than just calling requestExecute for a cell. It also involves posting results, ensuring a notebook is created and a bunch of other things.

It would be nice to make this more generic (like a service tied to a specific view) that would allow execution to be separated from the view itself. It modifies the view, but it doesn't exist on the view.

@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-python Nov 13, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants