Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor backend code related to notebooks #6950

Closed
6 of 8 tasks
greazer opened this issue Aug 2, 2021 · 2 comments
Closed
6 of 8 tasks

Refactor backend code related to notebooks #6950

greazer opened this issue Aug 2, 2021 · 2 comments
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues

Comments

@greazer
Copy link
Contributor

greazer commented Aug 2, 2021

  • Unwrap baseJupyterSession wrapper layers (INotebook and friends`)
  • Transition use of executeObservable in nativeInteractiveWindow to new kernelExecution.ts codepath
  • Remove dependence on ICell interface. We should directly deal with nbformat cells and notebooks
  • Add findMatchingWindow(uri: Uri) to IInteractiveWindowProvider and cleanup nativeInteractiveWindowCommandListener
  • One unified command handler for kernel restart and interrupt, shared across native notebooks and interactive window

Here's a set of issues from early 2020 that may or may not related to this work item. Feel free to just close if no longer applicable.

@greazer greazer added the bug Issue identified by VS Code Team member as probable bug label Aug 2, 2021
@greazer greazer changed the title Remove and refactor old code related to webview notebook editors Remove and refactor backend code related to webview notebook editors Aug 2, 2021
@greazer greazer added this to the August 2021 milestone Aug 13, 2021
@DonJayamanne DonJayamanne changed the title Remove and refactor backend code related to webview notebook editors Refactor backend code related to notebooks Aug 16, 2021
@DonJayamanne
Copy link
Contributor

Discussion points:

  • Interactive window should use Native Notebook Kernel provider & kernel execution for running cells
    Completed by @joyceerhl
  • Remove notion of Restarting Kernels & replace with Stop & Start new kernel
    • Today we have some specific code that deals with restarting kernels & re-initializing the kernel once it has been restarted. In reality the restart is identical to start, we end up with a brand new kernel and we need to run the initialization code again.

@greazer
Copy link
Contributor Author

greazer commented Mar 7, 2022

Closing. Much of this has been done or changed to the point that this issue no longer applies well. Using #8933 to track this type of work.

@greazer greazer closed this as completed Mar 7, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues
Projects
None yet
Development

No branches or pull requests

2 participants