-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When in ipynb, keyboard shortcut to close window or new tab triggers twice #2287
Comments
Hey @shern2 Thanks for reporting this and sorry about the issue. I'm trying to repro this issue now myself and I'm currently not seeing it: Could you send the output of the vs code Help->Toggle Developer Tools console log? That would have some output that might help me with diagnosing what is going on in this scenario. You can just right click on that console log to save off a copy of it. |
Thanks @IanMatthewHuff . Here's the logs: Scenario 1: vscodeBug_ctrlN.log Scenario 2: vscodeBug_ctrlW.log |
@shern2 Thanks for providing those logs. We actually just pushed out a point release yesterday. Would you mind updating to that (the extension should update automatically) and checking again? Also just to confirm, This is only in the notebook view? You don't see the double commands in normal code files of any type? Sorry about the extra questions, just still in the dark a bit here. Nothing revealing in the logs and we shouldn't be intercepting or messing with those vscode keybindings at all. |
@IanMatthewHuff Yes. This is only in the notebook view. I don't see double commands in No worries about extra qns.
|
Similar behavior to #2251. |
Yeah, we're confirmed this repros on Linux only. Bumping back to triage for consideration. |
Resolving this issue as it looks to be a general vscode issue. This is the issue to watch for the fix for this: |
Bug: Notebook Editor, Interactive Window, Editor cells
Steps to cause the bug to occur
scenario1: Closing a notebook
tmp.txt
) and open a notebook file.ctrl+w
to close window.scenario 2: Create new untitled file
ctrl+n
to create new untitled file.Actual behavior
Closing a notebook: both files are closed
Create new untitled file: 2 new files created
Expected behavior
Closing a notebook: Only opened file is closed
Create new untitled file: Only 1 new file created
The text was updated successfully, but these errors were encountered: