Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl+P when Release Notes is open, opens a recently open file #90579

Closed
MrSparc opened this issue Feb 13, 2020 · 11 comments
Closed

Ctrl+P when Release Notes is open, opens a recently open file #90579

MrSparc opened this issue Feb 13, 2020 · 11 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) webview Webview issues

Comments

@MrSparc
Copy link

MrSparc commented Feb 13, 2020

Issue Type: Bug

  1. After an update the "Release Notes: 1.42.0" is opened
  2. While active, press Ctrl + P "Go to File" keeping the Ctrl pressed for a few seconds, showing the list of recently open files
  3. When release the Ctrl key, automatically opens the recently open file that was selected by default instead of allow us to type any command

VS Code version: Code 1.42.0 (ae08d54, 2020-02-06T10:51:23.649Z)
OS version: Linux x64 4.12.14-lp151.28.36-default

System Info
Item Value
CPUs Intel(R) Core(TM) i7-6700T CPU @ 2.80GHz (8 x 2800)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: disabled_software
skia_renderer: disabled_off
surface_control: disabled_off
surface_synchronization: enabled_on
video_decode: unavailable_off
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) 2, 2, 2
Memory (System) 15.53GB (2.23GB free)
Process Argv . --no-sandbox
Screen Reader no
VM 0%
Extensions (25)
Extension Author (truncated) Version
language-x86-64-assembly 13x 2.2.11
latex-preview ajs 0.5.1
alignment ann 0.3.0
blamer-vs bea 0.5.2
vscode-eslint dba 2.0.15
xml Dot 2.5.0
vscode-svn eli 0.1.0
vscode-postman eri 1.0.2
vscode-peacock joh 3.3.1
svn-scm joh 2.7.0
chat kar 0.31.0
perl-debug mor 0.6.3
hg mrc 1.3.0
vscode-docker ms- 0.10.0
mssql ms- 1.8.0
python ms- 2020.2.63072
cpptools ms- 0.26.3
Go ms- 0.13.0
vsliveshare ms- 1.0.1587
vsliveshare-audio ms- 0.1.80
vsliveshare-pack ms- 0.3.4
java red 0.55.1
rust rus 0.7.0
omnipascal Wos 0.17.3
clang-format xav 1.9.0
@vscodebot
Copy link

vscodebot bot commented Feb 13, 2020

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@gjsjohnmurray
Copy link
Contributor

Probably a duplicate of #82670

@JacksonKearl
Copy link
Contributor

I can't reproduce. Are you opening the command pallet or the file picker? It's not clear to me what you mean by "open the Command Palette keeping the Ctrl pressed for a few seconds, showing the list of recently open files".

@JacksonKearl JacksonKearl added ~info-needed Issue requires more information from poster (with bot comment) and removed ~info-needed Issue requires more information from poster (with bot comment) labels Feb 13, 2020
@MrSparc
Copy link
Author

MrSparc commented Feb 14, 2020

Because a picture is worth a thousand words:
With Release Notes open and do Ctrl+P:
VSC_Ctrl+P_withReleaseNotes

Without Release Notes open and do Ctrl+P:
VSC_Ctrl+P_withoutReleaseNotes

Note that when the release notes are open and I press the shortcut "Ctrl + P" it opens the list of the most recent files, but just I release the keys it automatically opened the most recent file selected, not giving me chances of being able type in the name of the file I want to open.

In the second case, this does not happen.
What I noticed is that usually in the list of the most recent, the name of the file that is open in the tab always appears in the first position and selected, however when the problem occurs the "Release Notes" file does not appear in the first position selected.

@JacksonKearl JacksonKearl removed the ~info-needed Issue requires more information from poster (with bot comment) label Feb 14, 2020
@JacksonKearl
Copy link
Contributor

@MrSparc thanks, I can reproduce now. Seems to only happen on Linux.

@bpasero bpasero assigned mjbvz and unassigned bpasero Feb 14, 2020
@bpasero bpasero added the webview Webview issues label Feb 14, 2020
@bpasero
Copy link
Member

bpasero commented Feb 14, 2020

If it only reproduces in release notes, I suspect a webview issue with keybindings which #82670 is similar.

@IanMatthewHuff
Copy link
Member

IanMatthewHuff commented Feb 27, 2020

Just as a +1 on this. For the Python extension we use a number of webviews. If any of our webviews are opened Ctrl+* commands get doubled. Had a few reports on this already:
https://github.com/microsoft/vscode-python/issues/10147
https://github.com/microsoft/vscode-python/issues/10267

I was investigating our code when I realized that I could repro it not just with our stuff, but with the coding cat webview sample. So I checked and found this issue.

@gjsjohnmurray
Copy link
Contributor

@IanMatthewHuff are you on Linux too?

@ALL I assume it's intentionally convenient that if I hold Ctrl down, then press and release P to open the list, each subsequent press-and-release of P moves the list selector down one position. Similarly, Shift+P moves up one position. And when I finally release the Ctrl key it opens whatever item is currently selected.

@IanMatthewHuff
Copy link
Member

@gjsjohnmurray not normally, but when our customers reported this I checked it out on Linux. I only see this happen there, not on Mac or Windows.

@mjbvz
Copy link
Contributor

mjbvz commented Apr 17, 2020

Duplicate of #88284 I believe. I just checked in a fix but let me know if still see this in the next insiders build

@mjbvz mjbvz closed this as completed Apr 17, 2020
@mjbvz mjbvz added the *duplicate Issue identified as a duplicate of another issue(s) label Apr 17, 2020
@MrSparc
Copy link
Author

MrSparc commented Apr 27, 2020

I'm sorry, but this issue still happens in the release March 2020 (v1.44.2):
VSCMarch2020_Ctrl+P_withReleaseNotes

Update: Actually was fixed by #86790 with Milestone April 2020

@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) webview Webview issues
Projects
None yet
Development

No branches or pull requests

6 participants