Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of failed ipykernel installations & ipykernel detection #7902

Closed
8 tasks done
DonJayamanne opened this issue Oct 12, 2021 · 1 comment
Closed
8 tasks done
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Oct 12, 2021

We have plenty of scenarios where users are prompted to isntall ipykernel again & again.
This could happen when:

ipyhton_genutils is a great example of an upstrema bug, (ipykenrle removed that dependency), but was required by other packages in jupyter (which didn't specify that as a requirement).

Whats going on

  • Jupyter will get if ipykernel is installed (by importing ipykernel)
  • Python extension will prompt user to isntall ipykernel
  • Installation is a success
  • Jupyter will get a message saying it was not installed (as importing ipykernel fails)
  • No permissions to install in powershell

Thus, though ipykernel installatino ran successfully in temrinal, user gets a message that its not installed

Suggestion

@DonJayamanne DonJayamanne added the bug Issue identified by VS Code Team member as probable bug label Oct 12, 2021
@greazer greazer added this to the October 2021 milestone Oct 18, 2021
@rchiodo rchiodo modified the milestones: October 2021, November 2021 Oct 27, 2021
@DonJayamanne DonJayamanne changed the title Better handling of failed ipykernel installations Better handling of failed ipykernel installations & ipykernel detection Nov 5, 2021
@rchiodo rchiodo modified the milestones: November 2021, January 2022 Dec 6, 2021
@rchiodo rchiodo modified the milestones: January 2022, February 2022 Jan 27, 2022
@greazer greazer modified the milestones: February 2022, On Deck Feb 4, 2022
@DonJayamanne
Copy link
Contributor Author

Closing this issue, as we've addressed all of them

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

3 participants