Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install IPyKernel into all Python environments without the terminal #9376

Closed
DonJayamanne opened this issue Mar 15, 2022 · 2 comments
Closed
Labels
bug Issue identified by VS Code Team member as probable bug notebook-kernel Kernels issues (start/restart/switch, install ipykernel)
Milestone

Comments

@DonJayamanne
Copy link
Contributor

We found that installing ipykernel using shell doesn't work for a number of reasons (escaping paths, permissions in pwsh, etc).
& solved this for venvs by running the pip install by spawning a process.

We could try the same for all others and as a fall back, try the terminal.
This would work better in cases where conda isn't initialized in the vs code terminal.

TODO: Check whether this is still necessary as Rich may have already done this

@DonJayamanne DonJayamanne added the bug Issue identified by VS Code Team member as probable bug label Mar 15, 2022
@DonJayamanne DonJayamanne added notebook-kernel Kernels issues (start/restart/switch, install ipykernel) and removed bug Issue identified by VS Code Team member as probable bug labels Mar 15, 2022
@DonJayamanne
Copy link
Contributor Author

DonJayamanne commented Mar 15, 2022

Closing this as done & marking as bug to ensure this gets tested.

@DonJayamanne
Copy link
Contributor Author

Steps to test this:

  • Create a new conda environment
  • Run a cell against this, and when prompted to intall ipykernel click yes
  • Verify the installation does not happen in a Terminal

Repeat the same process for:

  • virtual environment
  • regular global python enviornment
  • Poetry environment

@DonJayamanne DonJayamanne added this to the March 2022 milestone Mar 16, 2022
@DonJayamanne DonJayamanne added the bug Issue identified by VS Code Team member as probable bug label Mar 16, 2022
@rchiodo rchiodo mentioned this issue Mar 21, 2022
2 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug notebook-kernel Kernels issues (start/restart/switch, install ipykernel)
Projects
None yet
Development

No branches or pull requests

2 participants