Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip checking ipykernel if interpreter has a kernel with kernelspec that has debugger flag set #8196

Closed
DonJayamanne opened this issue Nov 5, 2021 · 1 comment
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) perf Performance issues verified Verification succeeded
Milestone

Comments

@DonJayamanne
Copy link
Contributor

THe new ipykernel ends up creating kernlespec.json files with a debugger flag, that only works when a specific version of ipykernel is available in that environment.

I.e. if debugger is available, then ipykernle is available, hence no need to check if ipykernle is installed.

@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug kernel-enumeration perf Performance issues labels Nov 5, 2021
@DonJayamanne DonJayamanne removed bug Issue identified by VS Code Team member as probable bug needs-triage labels Nov 5, 2021
@DonJayamanne DonJayamanne added this to the November 2021 milestone Nov 24, 2021
@DonJayamanne DonJayamanne self-assigned this Nov 24, 2021
@DonJayamanne
Copy link
Contributor Author

Testing

  • Basically running cells should be faster, when running a cell against an existing kernel for second time.
  • YOu can look at the logs if you want to confirm we don't check for ipykernel (in the past we'd have lots indicating we're looking for ipykernle).

FYI - YOu don't need to test this, as its been covered elsewhere, but you can optionally look at the logs if you want to test this

@rchiodo rchiodo added the verified Verification succeeded label Dec 1, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2022
@DonJayamanne DonJayamanne added the *duplicate Issue identified as a duplicate of another issue(s) label Nov 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) perf Performance issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants