Updates to usage of PortAttributes VSC API #13506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amunger
approved these changes
May 16, 2023
|
Thanks for updating so quickly! |
alexr00
reviewed
May 24, 2023
There was a problem hiding this comment.
@DonJayamanne are you able to use a selector when you register the provider (first param here):
vscode-jupyter/src/kernels/portAttributeProvider.node.ts
Lines 20 to 21 in cd19546
I'm thinking about having an error if the selector is empty like this. The selector will result in a better experience for users as it will prevent extra trips to the extension host for ports that won't have attributes provided.
There was a problem hiding this comment.
@alexr00 please could you file an issue, so it never gets forgotten/lost
Will look into it when i get back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to changes in upstream vs code API