Decouple Variable View and Data Viewer #14359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package.json
Outdated
| @@ -1964,6 +1964,12 @@ | |||
| "type": "Python Interactive Window Debug Adapter", | |||
| "label": "%jupyter.debuggers.interactive%" | |||
| } | |||
| ], | |||
| "dataframeViewer": [ | |||
There was a problem hiding this comment.
jupyterVariableViewer
DonJayamanne
approved these changes
Sep 25, 2023
DonJayamanne
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re #14315.
The main change in this PR is decoupling data viewer and variable view. Data Viewer contributes a command for opening data frame and Variable View invokes that command other than directly depending on the data viewer component. So for users there should be no UI/UX change at this moment.
We also added an experiment, which once is turned on, it will then look at all data viewer contributions in the extensions installed locally, and use the contributed command to open the data frame or supported variable. This experiment is now fully turned off.
An example of how an extension can contribute a data viewer for Jupyter https://github.com/rebornix/vscode-data-grid-example
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).