Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request symbols only if document text in cell #15601

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Request symbols only if document text in cell #15601

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd4d5a5
Request symbols only if document text in cell
DonJayamanne Apr 24, 2024
bc476af
Merge branch 'main' into checkIfDocumentHasChanged
DonJayamanne Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/standalone/executionAnalysis/symbols.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,8 +259,10 @@ export class NotebookDocumentSymbolTracker {
});

e.cellChanges.forEach((change) => {
this._requestCellSymbols(change.cell, false).then(noop, noop);
this._updateCellStatus(change.cell, CellExecutionStatus.Stale);
if (change.document) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be done only when there are changes to the text in the cells

this._requestCellSymbols(change.cell, false).then(noop, noop);
this._updateCellStatus(change.cell, CellExecutionStatus.Stale);
}
});
}
})
Expand Down
Loading