Remove asyncDispose in session class #15657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
force-pushed
the
noAsyncDispose
branch
from
a86a05f
to
093f4e6
Compare
DonJayamanne
force-pushed
the
noAsyncDispose
branch
from
093f4e6
to
302abae
Compare
DonJayamanne
commented
May 3, 2024
|
|
||
| public get onDidKernelSocketChange() { | ||
| return this._onDidKernelSocketChange.event; | ||
| } | ||
| public abstract readonly status: KernelMessage.Status; | ||
| protected previousAnyMessageHandler?: IDisposable; | ||
| private disposeInvoked?: boolean; | ||
| public async disposeAsync(): Promise<void> { |
There was a problem hiding this comment.
disposeAsync(): Promise<void> removed in favour of dispose(): void and triggering the onDidDispose event
roblourens
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.