Update/reinstall if module was installed or exists #5738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5738 +/- ##
======================================
- Coverage 72% 72% -1%
======================================
Files 403 403
Lines 26865 26932 +67
Branches 3914 3926 +12
======================================
- Hits 19564 19488 -76
- Misses 5653 5804 +151
+ Partials 1648 1640 -8
|
|
@IanMatthewHuff thanks, i now know not to ignore the failures. |
DavidKutu
approved these changes
May 4, 2021
IanMatthewHuff
approved these changes
May 4, 2021
DonJayamanne
force-pushed
the
issue4758
branch
2 times, most recently
from
980b128
to
a35bafa
Compare
DonJayamanne
commented
May 4, 2021
| return controller; | ||
| } catch (ex) { | ||
| // We know that this fails when we have xeus kernels installed (untill that's resolved thats one instance when we can have duplicates). | ||
| sendTelemetryEvent( |
There was a problem hiding this comment.
If you install the xeus kernel, then everythings falls over. You cannot run any notebook, because we end up with duplicate kernels in our code.
This ensures we never end up in a situtaion where we're completely broken because of one bad apple.
Have a separate issue for handling xeus python kernels.
There was a problem hiding this comment.
Good catch @DonJayamanne I should install that kernel as well just to have for testing.
rchiodo
approved these changes
May 4, 2021
joyceerhl
reviewed
May 4, 2021
joyceerhl
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #4758
When re-installing for the second time ask user to re-install/update the package.
Requires a corresponding change in Python extension (that will be done seprately - separate repo, hence separate PR)
When ipykernel is detected (already found but we cannot import it), or if we have previously installed this, then the following error message is displayed;
