Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New API Changes #5813

Merged
merged 2 commits into from May 10, 2021
Merged

New API Changes #5813

merged 2 commits into from May 10, 2021

Conversation

IanMatthewHuff
Copy link
Member

For #5809

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).

@IanMatthewHuff IanMatthewHuff requested a review from a team as a code owner May 8, 2021 00:25
@IanMatthewHuff
Copy link
Member Author

IanMatthewHuff commented May 8, 2021

Per the VS Code team, this is the timeline for a Friday announced breaking change:

They are in notebook/dev now. On Monday, they will be merged to main. On Monday night, we will start the insiders build that contains these changes

My plan is to be oof on Monday, but I did set a reminder to log on and push these near end of day. However anyone else could merge this PR near the end of Monday just in case I forget while I'm oof. Just a simple rename.

@codecov-commenter
Copy link

codecov-commenter commented May 8, 2021

Codecov Report

Merging #5813 (3730112) into main (b184285) will decrease coverage by 10%.
The diff coverage is 16%.

@@           Coverage Diff           @@
##            main   #5813     +/-   ##
=======================================
- Coverage     72%     61%    -11%     
=======================================
  Files        403     403             
  Lines      26924   26924             
  Branches    3926    3926             
=======================================
- Hits       19428   16514   -2914     
- Misses      5874    9020   +3146     
+ Partials    1622    1390    -232     
Impacted Files Coverage Δ
...science/interactive-common/notebookUsageTracker.ts 23% <0%> (-49%) ⬇️
src/client/datascience/notebook/helpers/helpers.ts 43% <0%> (-33%) ⬇️
...lient/datascience/variablesView/notebookWatcher.ts 52% <50%> (-39%) ⬇️
...ient/datascience/jupyter/kernels/kernelProvider.ts 16% <0%> (-80%) ⬇️
.../datascience/jupyter/kernels/cellExecutionQueue.ts 10% <0%> (-79%) ⬇️
...ience/variablesView/variableViewMessageListener.ts 22% <0%> (-78%) ⬇️
...client/datascience/commands/activeEditorContext.ts 11% <0%> (-78%) ⬇️
...ent/common/application/webviewViews/webviewView.ts 14% <0%> (-72%) ⬇️
.../datascience/notebook/notebookControllerManager.ts 13% <0%> (-71%) ⬇️
...t/datascience/notebook/vscodeNotebookController.ts 9% <0%> (-69%) ⬇️
... and 156 more

@DonJayamanne DonJayamanne merged commit e6e8961 into main May 10, 2021
@DonJayamanne DonJayamanne deleted the dev/ianhu/newBreakingChanges branch May 10, 2021 23:27
@IanMatthewHuff
Copy link
Member Author

Thanks @DonJayamanne

DonJayamanne added a commit that referenced this pull request May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants