Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get prerelease working #8648

Merged
merged 17 commits into from
Jan 6, 2022
Merged

Get prerelease working #8648

merged 17 commits into from
Jan 6, 2022

Conversation

rchiodo
Copy link
Contributor

@rchiodo rchiodo commented Jan 6, 2022

Publish test

Finish support for microsoft/vscode#15756

@rchiodo rchiodo requested a review from a team as a code owner January 6, 2022 01:04
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2022

Codecov Report

Merging #8648 (8ecebdb) into main (58bd11b) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #8648   +/-   ##
=====================================
- Coverage     71%     71%   -1%     
=====================================
  Files        382     382           
  Lines      24522   24526    +4     
  Branches    3764    3766    +2     
=====================================
- Hits       17628   17546   -82     
- Misses      5377    5456   +79     
- Partials    1517    1524    +7     
Impacted Files Coverage Δ
...ience/variablesView/variableViewMessageListener.ts 77% <0%> (-23%) ⬇️
src/client/datascience/commands/serverSelector.ts 86% <0%> (-14%) ⬇️
...ent/common/application/webviewViews/webviewView.ts 67% <0%> (-11%) ⬇️
...ient/datascience/jupyter/kernels/kernelProvider.ts 90% <0%> (-8%) ⬇️
...rc/client/datascience/commands/notebookCommands.ts 40% <0%> (-7%) ⬇️
src/client/activation/activationManager.ts 56% <0%> (-5%) ⬇️
...ience/notebook/kernelFilter/kernelFilterService.ts 41% <0%> (-5%) ⬇️
...ce/raw-kernel/liveshare/hostRawNotebookProvider.ts 80% <0%> (-5%) ⬇️
...t/common/variables/environmentVariablesProvider.ts 71% <0%> (-5%) ⬇️
...ient/datascience/data-viewing/dataViewerFactory.ts 82% <0%> (-5%) ⬇️
... and 25 more

@rchiodo rchiodo changed the title Trivial change Get prerelease working Jan 6, 2022
@IanMatthewHuff
Copy link
Member

What's this PR about?

@rchiodo
Copy link
Contributor Author

rchiodo commented Jan 6, 2022

What's this PR about?

This turns on 'prerelease' bits. VS code supports prerelease now. Don had partially enabled it but the vsce package command required another command line argument.

@IanMatthewHuff
Copy link
Member

What's this PR about?

This turns on 'prerelease' bits. VS code supports prerelease now. Don had partially enabled it but the vsce package command required another command line argument.

Cool, didn't realize that was a thing...How does that overlap with expected users of our insiders build (since we already have daily build there)? Actually I can just ask at the notebook sync today.

@rchiodo rchiodo merged commit a9912fc into main Jan 6, 2022
@rchiodo rchiodo deleted the rchiodo/publish branch January 6, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants