Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #1046

Merged
merged 1 commit into from Aug 4, 2022
Merged

Update dependencies #1046

merged 1 commit into from Aug 4, 2022

Conversation

dbaeumer
Copy link
Member

@dbaeumer dbaeumer commented Aug 3, 2022

No description provided.

@dbaeumer dbaeumer enabled auto-merge (squash) August 3, 2022 15:42
@dbaeumer
Copy link
Member Author

dbaeumer commented Aug 3, 2022

Update dependencies to fix depbot allert.

@dbaeumer dbaeumer requested a review from alexr00 August 3, 2022 15:43
@dbaeumer dbaeumer mentioned this pull request Aug 3, 2022
Closed
@dbaeumer dbaeumer merged commit 5784c98 into main Aug 4, 2022
@dbaeumer dbaeumer deleted the dbaeumer/inquisitive-stoat-olive branch August 4, 2022 09:50
@Ehesp
Copy link

Ehesp commented Aug 18, 2022

@dbaeumer @alexr00 would it be possible to publish a new release with this change?

@dbaeumer
Copy link
Member Author

@Ehesp could you explain why?

@Ehesp
Copy link

Ehesp commented Aug 19, 2022

@dbaeumer Sure, https://github.com/TypeFox/monaco-languageclient/blob/main/packages/client/package.json#L58 currently points to 8.0.2, which includes the v3 minimatch package, which causes this issue #1038

@dbaeumer
Copy link
Member Author

Will look into it after end game week (which is this week).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexr00 alexr00 alexr00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dbaeumer @Ehesp @alexr00