Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed Successful Exit Notification for Node Client #1404

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Changed Successful Exit Notification for Node Client #1404

merged 2 commits into from
Jan 11, 2024

Conversation

rroessler
Copy link
Contributor

Previously any exit code (even 0), were logged as error messages. Now successful exits are instead logged as an information message.

For more information see:

  • Commit where exit code capturing was added.

@rroessler
Change Successful Exit Notification
e4406c0 
Previously any exit code (even 0), were logged as error messages. Now successful exits are instead logged as an information message.
@rroessler rroessler mentioned this pull request Jan 10, 2024
Closed
@dbaeumer dbaeumer enabled auto-merge (squash) January 11, 2024 13:17
@VSCodeTriageBot VSCodeTriageBot added this to the December / January 2024 milestone Jan 11, 2024
@dbaeumer dbaeumer merged commit edadf71 into microsoft:main Jan 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbaeumer dbaeumer dbaeumer approved these changes

@aeschli aeschli aeschli approved these changes

@chrmarti chrmarti chrmarti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rroessler @dbaeumer @aeschli @chrmarti @VSCodeTriageBot