Support pulling diagnostics for notebooks too #1465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dbaeumer do you see these automatically? Sorry wasn't sure if you saw this or not. |
|
Yes, I do but I was out sick last week :-( |
|
Great work. I highly appreciate the effort. See my comments. I am open for discussion since I might have missed some design choices as well. |
dbaeumer
requested changes
Apr 29, 2024
52 tasks
dbaeumer
requested changes
May 8, 2024
|
Looks good to me. Only one small request for change. |
dbaeumer
approved these changes
May 13, 2024
|
@rchiodo thanks again for the great PR. |
alexdima
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1464
Please let me know if this is acceptable. Wasn't sure if formatting was correct or if I did something weird in the testing.
I also tested this using the Pylance extension to verify I do receive pull diagnostics requests for notebooks in Pylance.