Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable notification Makefile entry point not found #394

Closed
alexreg opened this issue Dec 7, 2022 · 6 comments · Fixed by #415
Closed

Disable notification Makefile entry point not found #394

alexreg opened this issue Dec 7, 2022 · 6 comments · Fixed by #415
Projects
Milestone

Comments

@alexreg
Copy link

alexreg commented Dec 7, 2022

Is there any way to disable the notification Makefile entry point not found? I find myself encountering this quote often, since many projects only have makefiles in subdirectories, for specific tasks. Ideally the extension wouldn't activate at all in this case, but I'd settle for hiding this notification.

@bobbrow
Copy link
Member

bobbrow commented Dec 9, 2022

Thanks for reporting this. I see this too. We can make this better. I'll put it on the backlog for 0.7.

@bobbrow bobbrow added this to To do in 0.7.0 via automation Dec 9, 2022
@bobbrow bobbrow added this to the 0.7.0 milestone Dec 9, 2022
@alexreg
Copy link
Author

alexreg commented Dec 10, 2022

@bobbrow Great, appreciate it.

@danielb2
Copy link

danielb2 commented Feb 6, 2023

What is the purpose of the notification at all? Seems it should be disabled by default if made into an option. I just wonder if it needs to be even an option, and it should't happen. I don't know it's purpose

@ushuz
Copy link
Contributor

ushuz commented Feb 7, 2023

As a workaround, you can modify the extension code and disable the notification for now:

// .vscode/extensions/ms-vscode.makefile-tools-0.6.0/out/src/configuration.js
...
        if (!util.checkFileExistsSync(makefileUsed)) {
            // vscode.window.showErrorMessage(localize(1, null, "Makefile"));
            logger.message("The makefile entry point was not found. " +
...

@andreeis
Copy link
Contributor

@ushuz , @danielb2 , @alexreg , we removed the popup notifications regarding makefile and make missing, we left the logging about that unchanged and we are also showing now the "C/C++" tab UI on the left side even when before it was hidden. In there we add now some extra elements about status on make/makefile/build.log: path where we search for them, if not found, you can click the edit pen icon to open settings and change this state via settings like "makefile.makefilePath", "makefile.makePath", "makefile.buildLog" and their "makefile.configurations[]" counterparts.

This will be released with 0.7 next week but if you would like to see how this works earlier you can install one vsix from this link.

go to the Extensions panel on the left
click "..."
run "Install from vsix" from the context menu

Let us know if you encounter any other issues or if you have any other suggestions/recommendations in this area of functionality.

@alexreg
Copy link
Author

alexreg commented Mar 17, 2023

@andreeis Okay, that sounds like a good solution. I'll have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
0.7.0
Done
Development

Successfully merging a pull request may close this issue.

5 participants