-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regular expressions take up too much time #576
Comments
@gcampbell-msft |
@SeasClouds Is this a suggestion you're making? I'm not sure I fully understand this issue, could you provide more information and context? |
Yes, it's a suggestion , when there is no "$(", regular matching can be skipped |
@SeasClouds Ah, understood. We'd be happy to consider taking an open source contribution for this! Would you be willing to make a PR? |
@gcampbell-msft I am happy to contribute to open source. I will submit a PR in my free time, but I don't think it's a good solution as it still takes up a lot of time when encountering "$(" |
@SeasClouds I understand that you're still requesting a perf improvement for the regex, but if this at least improves the non regex case, then I think it's worth contributing. |
Regular expression processing takes up a total of 80% of the time during preprocessing
Do a check before using regular expressions,Does that leave anything out?
The text was updated successfully, but these errors were encountered: