Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The preview version does not appear to be working properly #590

Open
SeasClouds opened this issue Apr 29, 2024 · 5 comments
Open

The preview version does not appear to be working properly #590

SeasClouds opened this issue Apr 29, 2024 · 5 comments
Labels
fixed-pending-release Fix is merged and will be included in the next release.

Comments

@SeasClouds
Copy link
Contributor

I updated to the preview version (v0.10.5) and it is not working properly. didn't handle dry-run output, and didn't communicate with the cpp extension.
Normal after running Makefile: Clean Configure
image
@gcampbell-msft
Copy link
Collaborator

@SeasClouds Am I understanding you correctly that running Makefile: Clean Configure fixes the issue? If not, I'm not sure what you mean by "Normal after running Makefile: Clean Configure"

@SeasClouds
Copy link
Contributor Author

SeasClouds commented Apr 29, 2024 •
edited

@gcampbell-msft Running Makefile: Clean Configure can fix this issue, but every time vscode is opened, it is necessary to run Makefile: Clean Configure

@gcampbell-msft
Copy link
Collaborator

@seascloud What is your makefile.configureOnOpen setting set to? Could you set it to true and see if this issue goes away?

@SeasClouds
Copy link
Contributor Author

@gcampbell-msft Setting it to true still raises the issue.
This issue should be caused by #573 submission. When extension.getFullFeatureSet() and configuration.getConfigOnOpen() return true, make.cleanConfigure(make.TriggeredBy.cleanConfigOnOpen) will not run. Is this your expectation

@gcampbell-msft
Copy link
Collaborator

@SeasClouds Ah, great catch, I'll fix this

@gcampbell-msft gcampbell-msft mentioned this issue Apr 30, 2024
Merged
@gcampbell-msft gcampbell-msft added fixed-pending-release Fix is merged and will be included in the next release. and removed triage labels Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed-pending-release Fix is merged and will be included in the next release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SeasClouds @gcampbell-msft