Remove dry-run popup, replace with configureOnOpen questions#573
Merged
gcampbell-msft merged 9 commits intomainfrom Mar 29, 2024
Merged
Remove dry-run popup, replace with configureOnOpen questions#573gcampbell-msft merged 9 commits intomainfrom
gcampbell-msft merged 9 commits intomainfrom
Conversation
elizabethmorrow
approved these changes
Mar 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most importantly, this removes the problematic and frustrating to users dry-run pop-up.
When you open a workspace that has a Makefile, you will first be prompted with this pop-up.
Then, the makefile extension will start the configure process, and also give you this pop-up that will control what level we will save your choice in, either globally or only in this workspace.
However, if you say no to the first pop-up, the configure process will not be started, and then you will be prompted with this:
This will allow you to either globally turn off configuring on open, or only for the current workspace.