Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Markdown supports does not deal with multibyte character #17

Closed
Yarakashi-Kikohshi opened this issue May 24, 2022 · 1 comment · Fixed by #142
Closed

Some Markdown supports does not deal with multibyte character #17

Yarakashi-Kikohshi opened this issue May 24, 2022 · 1 comment · Fixed by #142
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug markdown

Comments

@Yarakashi-Kikohshi
Copy link

This problem still occurs even if you disable all extensions and occurs in both stable and insider.

The following features do not deal with multibyte characters well. It encodes multibyte characters. Do not encode.

The path intellisense for headings works correctly.
Markdown rename support includes “Rename reference links”, but reference links works correctly.

Demonstrations

  .
  |- テスト1.md
  `- テスト2.md
<!-- テスト1.md -->
# 見出し

[見出し](#見出し)

[Visual Studio Code April 2022][vscode]

[vscode]: https://code.visualstudio.com/updates/v1_67

[テスト2の見出し](テスト2.md#見出し)
<!-- テスト2.md -->
# 見出し
  • Markdown path IntelliSense

    Image path IntelliSense

  • Drop into editor to create link

    Image Drop into editor to create link

  • Rename Headers

    Image Rename headers

    Image Rename headers

  • Rename Files

    Image Rename files

Rename reference links works correctly.

Image Rename reference links

Version

 Version: 1.67.2 (user setup)
  Commit: c3511e6c69bb39013c4a4b7b9566ec1ca73fc4d5
    Date: 2022-05-17T18:15:52.058Z
Electron: 17.4.1
Chromium: 98.0.4758.141
 Node.js: 16.13.0
      V8: 9.8.177.13-electron.0
      OS: Windows_NT x64 10.0.19043
 Version: 1.68.0-insider (user setup)
  Commit: c0769274fa136b45799edeccc0d0a2f645b75caf
    Date: 2022-05-23T05:17:12.256Z
Electron: 17.4.4
Chromium: 98.0.4758.141
 Node.js: 16.13.0
      V8: 9.8.177.13-electron.0
      OS: Windows_NT x64 10.0.19043
@Yarakashi-Kikohshi Yarakashi-Kikohshi changed the title Some Markdown IntelliSense support does not deal with multibyte character Some Markdown supports does not deal with multibyte character May 24, 2022
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug markdown labels May 24, 2022
@mjbvz mjbvz transferred this issue from microsoft/vscode Aug 5, 2022
mjbvz added a commit to mjbvz/vscode-markdown-languageservice that referenced this issue Jun 5, 2023
@mjbvz
Copy link
Contributor

mjbvz commented Jun 5, 2023

Please give this another try later once the fix is merged into VS Code 1.80. I've fixed a number of different cases here but may have overlooked a few

We should now be more selective about encoding paths rather than always encoding them

@mjbvz mjbvz closed this as completed in #142 Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug markdown
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants