Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strikethrough support #101

Merged
merged 2 commits into from Jan 5, 2022
Merged

Add strikethrough support #101

merged 2 commits into from Jan 5, 2022

Conversation

ghost
Copy link

@ghost ghost commented Dec 18, 2021

Part of microsoft/vscode#43504 - some useful tests I'd propose:

  • ~
  • ~~
  • nested italics/bold in strikethrough
  • nested inline code works and doesn't allow formatting inside the code

Closes #100.

@ghost
Copy link
Author

ghost commented Dec 22, 2021

@mjbvz I don't have view permissions on the tests. Any reason why the Windows job failed?

@mjbvz mjbvz merged commit a8545b2 into microsoft:main Jan 5, 2022
@mjbvz
Copy link
Contributor

mjbvz commented Jan 5, 2022

Nice work! Thanks. Will be in the next VS Code insiders build and in VS Code 1.64 if everything looks good

@ghost ghost deleted the feat-strikethrough branch January 5, 2022 22:33
@ghost
Copy link
Author

ghost commented Jan 5, 2022

I think this would go great in microsoft/vscode#139688 :) syncing as we speak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add markup.strikethrough for tilde syntax
1 participant