Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There should be an "Execute Query" run button in SQL editor toolbar #1443

Closed
kburtram opened this issue Oct 17, 2019 · 3 comments · Fixed by #1556
Closed

There should be an "Execute Query" run button in SQL editor toolbar #1443

kburtram opened this issue Oct 17, 2019 · 3 comments · Fixed by #1556

Comments

@kburtram
Copy link
Member

  • MSSQL Extension Version: 1.7

It would be better if there were "Run" and "Stop" buttons in the SQL editor toolbar for starting and canceling query execution. For example, see how the Python extension uses a toolbar in .ipynb notebook files.

image

@kburtram kburtram added this to the MSSQL 1.8 Release milestone Nov 14, 2019
@abist abist removed this from the MSSQL 1.8 Release milestone Nov 15, 2019
@abist
Copy link
Contributor

abist commented Nov 15, 2019

This can't make the 1.8 milestone since VS Code doesn't give the ability to add your own commands with icons in the editor - microsoft/vscode#41309

@kburtram kburtram added this to the MSSQL 1.9 Release milestone Dec 19, 2019
@kburtram
Copy link
Member Author

@abist it looks like the Python extension is able to do this with .py files as show below. They don't appear to be using a custom editor in this case, so I would suspect we can do the same for .sql files?

image

@abist
Copy link
Contributor

abist commented Dec 19, 2019

@kburtram I was able to confirm and add it to the extension in my testing internally. This should be easily doable.

@abist abist mentioned this issue Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants