Editor/icons #1556
Merged
Editor/icons #1556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonydresser
approved these changes
Dec 19, 2019
|
@anthonydresser These icons are theme based, and from ADS. What do you mean by using our own icons? |
vscode recently added the ability to specify icons coming from the icon theme the user is using, rather than providing your own. This adds greater theme awareness other than just light/dark. |
|
@anthonydresser will look into it! |
|
It might still be in preview, https://github.com/microsoft/vscode/blob/master/src/vs/platform/actions/common/actions.ts#L26 I just remember seeing it. |
|
e.x you could utilize the same icon as what is being used in the debugger. looks like the id for start there is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1443 (comment)