Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't respond to changes to pyproject.toml #122

Open
samskiter opened this issue Aug 17, 2023 · 4 comments · May be fixed by #163
Open

Doesn't respond to changes to pyproject.toml #122

samskiter opened this issue Aug 17, 2023 · 4 comments · May be fixed by #163
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug good first issue Good for newcomers needs PR

Comments

@samskiter
Copy link
Contributor

Other extensions (like pylance) will restart/reload settings if pyproject.toml changes, but I need to manually restart this extension to pick up any changes I make.

@karthiknadig
Copy link
Member

@samskiter This is a limitation of dmypy as it does not re-read pyproject.toml. However, this is an easier fix in the extension to restart the server. This can be done using workspace file-watcher with a pattern that includes all the various settings files. The water needs to track changed events and trigger restart.

@karthiknadig karthiknadig added bug Issue identified by VS Code Team member as probable bug needs PR and removed triage-needed labels Aug 17, 2023
@samskiter
Copy link
Contributor Author

This is beyond my ability / time availability right now I'm afraid, but would love to see this implemented to have behaviour parity with other python extensions (this took me a while to realise when fiddling with my project settings)

@luabud luabud added good first issue Good for newcomers ghc-osd labels Sep 14, 2023
@luabud
Copy link
Member

luabud commented Sep 18, 2023

We are reserving this issue for Grace Hopper's Open Source Day, which will take place on September 22nd, 2023. If you're part of the event and would like to submit a contribution to this issue, please let us know, and we'll be happy to assign it to you.

For other community members who are not participating in the event, we appreciate your interest in contributing! We kindly request that you wait until after September 22nd to work on this issue. If no one from the event has been assigned to it by then, we'll gladly assign it to you. Thank you for your understanding and support!

@xytian315
Copy link

xytian315 commented Sep 22, 2023

@karthiknadig grace hopper participant.
interested to take this issue.

@xytian315 xytian315 linked a pull request Sep 23, 2023 that will close this issue
@luabud luabud removed the ghc-osd label Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug good first issue Good for newcomers needs PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants