-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Macbook-Pro's touch bar support #75
Conversation
@matextrem sorry I was heads down working the vscode-remote stuff. Will look into this this week. |
@matextrem this looks interesting. Some feedback:
|
@egamma Thanks you so much for your feedback! I have recently updated the PR with the changes you requested. |
LGTM, thanks! |
Published to the market place. |
is there an option do disable these touchbar options form showing? |
@Coollision currently not, but it would make sense to provide a setting to disable the touchbar contributions. @matextrem it is pretty straightforward to support this. Would you be willing to enrich the PR? I suggest to add a setting "touchBar": [
{
"command": "npm-script.install",
"group": "navigation@+1",
"when": "config.npm.enableTouchbar"
} |
@egamma Thanks for the info, I am looking forward to the update. |
@egamma I will do it ASAP! @Coollision Thank you for your feedback! |
Being able to enable/disable the touchbar would be a welcome change. For me, I was using NASC to configure the touchbar to my liking. It would be nice to be able to use the npm extension, while keeping my old touchbar configuration. |
When I do the build command, I get this error: npm WARN build `npm build` called with no arguments. Did you mean to `npm run-script build`? Should I think the change needs to be made to this line: vscode-npm-scripts/src/main.ts Line 469 in 2c0a065
|
Add support for Macbook-pro's touch bar for the most commonly used commands.
You can run the following commands: