Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Macbook-Pro's touch bar support #75

Merged
merged 4 commits into from
May 7, 2019

Conversation

matextrem
Copy link

Add support for Macbook-pro's touch bar for the most commonly used commands.

touchbar-support

You can run the following commands:

  • npm install
  • npm start
  • npm test
  • npm build

@msftclas
Copy link

msftclas commented Apr 20, 2019

CLA assistant check
All CLA requirements met.

@matextrem
Copy link
Author

@egamma

@egamma
Copy link
Member

egamma commented May 6, 2019

@matextrem sorry I was heads down working the vscode-remote stuff. Will look into this this week.

@egamma
Copy link
Member

egamma commented May 6, 2019

@matextrem this looks interesting.

Some feedback:

  • it looks like you changed the format of the package.json and the diff shows everything as changed, which makes it difficult to review. Please fix the formatting.
  • please exclude assets/.DS_Store from the PR.

@matextrem
Copy link
Author

@egamma Thanks you so much for your feedback! I have recently updated the PR with the changes you requested.

@egamma egamma merged commit 59e1f3e into microsoft:master May 7, 2019
@egamma
Copy link
Member

egamma commented May 7, 2019

LGTM, thanks!

@egamma
Copy link
Member

egamma commented May 7, 2019

Published to the market place.

@Coollision
Copy link

is there an option do disable these touchbar options form showing?

@egamma
Copy link
Member

egamma commented May 8, 2019

@Coollision currently not, but it would make sense to provide a setting to disable the touchbar contributions.

@matextrem it is pretty straightforward to support this. Would you be willing to enrich the PR?

I suggest to add a setting npm.enableTouchbar. You can then enable the touch bar depending on the value of this setting using a when clause:

"touchBar": [
		{
			"command": "npm-script.install",
			"group": "navigation@+1",
			"when": "config.npm.enableTouchbar"
		}

@Coollision
Copy link

@egamma Thanks for the info, I am looking forward to the update.

@matextrem
Copy link
Author

@egamma I will do it ASAP!

@Coollision Thank you for your feedback!

@jlw8ke
Copy link

jlw8ke commented May 8, 2019

Being able to enable/disable the touchbar would be a welcome change. For me, I was using NASC to configure the touchbar to my liking. It would be nice to be able to use the npm extension, while keeping my old touchbar configuration.

@chrislim
Copy link

When I do the build command, I get this error:

npm WARN build `npm build` called with no arguments. Did you mean to `npm run-script build`?

Should npm build be npm run build?

I think the change needs to be made to this line:

function runNpmBuild() {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants