Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After many files in a large PR the last files redirect to Github instead of opening the diff #1160

Closed
YLivay opened this issue May 16, 2019 · 4 comments
Labels
feature-request Request for new features or functionality github Related to GitHub API

Comments

@YLivay
Copy link

YLivay commented May 16, 2019

Issue Type: Bug

  1. Checkout the branch the PR is on locally
  2. Open a large PR with many files in the extension
  3. Click the last files on the list in vscode

Expected: Should open the diff in vscode
Actual: Redirects to view the file on Github.com

Sounds like it may be related to #552
Even if I have the branch checked out, past ~170 files clicking the files redirect to view the blob in Github instead of showing the diff.

Extension version: 0.6.0
VS Code version: Code 1.33.1 (51b0b28134d51361cf996d2f0a1c698247aeabd8, 2019-04-11T08:20:22.771Z)
OS version: Linux x64 5.0.13-300.fc30.x86_64

@RMacfarlane
Copy link
Contributor

Hey @YLivay, this is a duplicate of #442. There are some situations where we cannot fetch the file content so we redirect to GitHub (if the change was just a file rename, or the file is an unsupported type, for example). I just merged in a PR from the community to show a notification in such a case.

@YLivay
Copy link
Author

YLivay commented May 25, 2019

Hey @RMacfarlane, I don't think this is a duplicate. This issue is about well supported files not being handled. The files that are not handled are only the last ones on the list, and they are the same type as the files that were returned. I'm assuming GitHub is just not returning the last entries because of the sheer size of the request. I'm hoping there's a way to break it apart to multiple requests instead of having the extension give up past a few hundred files.

I don't know if this helps but I turned the debug mode for the extension and verified that the files are simply not returned in the GraphQL response the extension is printing out.

@RMacfarlane
Copy link
Contributor

@YLivay Ok, thanks for clarifying!

@alexr00
Copy link
Member

alexr00 commented Jun 23, 2022

Should be fixed by #3623

@alexr00 alexr00 closed this as completed Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality github Related to GitHub API
Projects
None yet
Development

No branches or pull requests

3 participants