Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when handling outdated comments #2831

Closed
sfc-gh-sgiesecke opened this issue Jul 8, 2021 · 4 comments
Closed

Error when handling outdated comments #2831

sfc-gh-sgiesecke opened this issue Jul 8, 2021 · 4 comments
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@sfc-gh-sgiesecke
Copy link

  • Extension version: 0.26.0
  • VSCode Version: 1.56.2
  • OS: CentOS / Linux

Steps to Reproduce:

  1. Open a PR and file with outdated comments

Expected behaviour:

Outdated comments are somehow visible

Actual behaviour:

Errors in log like

[Info] Failed to parse patch for outdated comments: Failed to execute git {
  "exitCode": 128,
  "gitCommand": "diff",
  "stdout": "",
  "stderr": "fatal: Invalid symmetric difference expression 493338c5e5666ea78107a7397a739cb6326dbf22...38a6634c3392755b47f24b4867d32916fc6310bd\n"
}
@alexr00
Copy link
Member

alexr00 commented Jul 9, 2021

@sfc-gh-sgiesecke do you have a PR in a public repo that you can share a link to?

@alexr00 alexr00 added the info-needed Issue requires more information from poster label Jul 9, 2021
@sfc-gh-sgiesecke
Copy link
Author

Unfortunately not, I have used the extension only with a private repo so far.

@0xabu
Copy link

0xabu commented Sep 10, 2021

[Moved to new issue #2997 since there is no error.]

@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Nov 22, 2021
@alexr00
Copy link
Member

alexr00 commented Dec 12, 2022

I haven't been able to reproduce this issue and there have been no further reports. If it happens again I will investigate further!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

3 participants