Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to read outdated comments #33

Closed
joaomoreno opened this issue Jun 26, 2018 · 2 comments
Closed

Failed to read outdated comments #33

joaomoreno opened this issue Jun 26, 2018 · 2 comments
Labels
bug Issue identified by VS Code Team member as probable bug comments upstream/vscode

Comments

@joaomoreno
Copy link
Member

I opened a PR which had outdated comments (changes were added on top of other changes which had comments):

One of the comments seems to appear nicely (use lower-case uri for consistency)... The other gets the Commenting is not supported outside of diff hunk areas. warning when clicked, even though I just want to read it, not comment on it:

screen shot 2018-06-26 at 16 04 49

@rebornix rebornix added the bug Issue identified by VS Code Team member as probable bug label Jun 27, 2018
@rebornix
Copy link
Member

I no longer see this issue happening. When a file which contains an outdated comment, the comment is displayed and a comment affordance is displayed near the line number, clicking on it doesn't trigger any warning popup. I'd like to close this one first, if you run into this issue again, feel free to reopen it.

@rebornix
Copy link
Member

We still have UX issues with how to show outdated comments but we don't track it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug comments upstream/vscode
Projects
None yet
Development

No branches or pull requests

4 participants