Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11y_Visual Studio Code Web Extensions_Github_Description_Keyboard: On closing the "Do you want Code - Insiders to open the external website?" popup, the focus does not return to the 'Image' present under the text before associated with the comment shared by Thomus1664 #4242

Open
sspatil123 opened this issue Nov 25, 2022 · 2 comments

Comments

@sspatil123
Copy link

sspatil123 commented Nov 25, 2022

Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.”

GitHubTags:#A11yMAS;#A11yTCS;#GH_Visual Studio Code Web Extensions_Nov2022;#Visual Studio Code Web Extensions ;#ChromiumEdge;#DesktopWeb;#A11ySev3;#Win11;#WCAG2.4.3;#Keyboard;#External;#External:GitHub;#External:Bug170442;

Environment Details:

Application Name: Visual Studio Code Web Extensions
URL: https://insiders.vscode.dev/github/microsoft/vscode-pull-request-github
Windows Version: Win11
Edge version:107.0.1418.56

Repro Steps:

  1. Please do not close this bug. This bug should only be closed by TCS, C+AI Accessibility tester after verification of the fix
  2. Open https://insiders.vscode.dev/github/microsoft/vscode-pull-request-github environment and login with git hub account.
  3. tab to 'Github' and press enter.
  4. tab to 'All Open' and press enter.
  5. Tab to any pull request and press enter 'Description'.
  6. Tab till 'Image' link and press enter.
  7. Check after closing dialog focus is return back to same control or not.

Actual:

On closing the "Do you want Code - Insiders to open the external website?" popup, the focus does not return to the 'Image' present under the text before associated with the comment shared by Thomus1664.

Expected:

On closing the "Do you want Code - Insiders to open the external website?" popup, the focus Should be return to the 'Image' present under the text before associated with the comment shared by Thomus1664.

User Impact:

Keyboard user will not get the right order of navigation back to the 'Image' link.

Attachment:

FocusOrderIncorrect

@alexr00 alexr00 added this to the December 2022 milestone Nov 28, 2022
@sspatil123 sspatil123 changed the title A11y_Visual Studio Code Web Extensions_Github_Description_Keyboard: On closing the "Do you want Code - Insiders to open the external website?" popup, the focus does not return to 'Image' link. A11y_Visual Studio Code Web Extensions_Github_Description_Keyboard: On closing the "Do you want Code - Insiders to open the external website?" popup, the focus does not return to the 'Image' present under the text before associated with the comment shared by Thomus1664 Nov 30, 2022
@fsteffi
Copy link

fsteffi commented Jan 9, 2023

external bug:microsoft/vscode#170442

@alexr00 alexr00 self-assigned this Jan 9, 2023
@alexr00 alexr00 removed this from the January 2023 milestone Jan 9, 2023
@sspatil123
Copy link
Author

Reducing to Sev3 #A11ySev3; as per comment of bug microsoft/vscode#170442

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants