Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github pr extension is unable to sign in, while other extensions are fine #5785

Open
syffs opened this issue Feb 27, 2024 · 6 comments
Open
Labels
info-needed Issue requires more information from poster

Comments

@syffs
Copy link

syffs commented Feb 27, 2024

  • Extension version: 0.80.1
  • VSCode Version: 1.86.2
  • OS: W11 Pro
  • Repository Clone Configuration (single repository/fork of an upstream repository): single repository
  • Github Product (Github.com/Github Enterprise version x.x.x): Github.com

Steps to Reproduce:

  1. Installed Github Pull Requests extension
  2. Signed in/out multiple times from github
  3. Github Copilot / Copilot chat extensions work well
  4. Github Pull Requests extension keep showing the same pane with "You have not yet signed in with GitHub", and clicking on Sign in does not do anything:
image
@bavarianbidi
Copy link

bavarianbidi commented Feb 27, 2024

I have a similar issue (and wanted to create an issue when i've seen this one 😅 ) where my enterprise-managed account (where the Copilot-license is handled) conflict with the PullRequest extension and my personal account which i'm using for normal operations.

My current findings so far:

  • since v0.76.0 the PR plugin has support for Copilot generated PR/Issue titles
  • This requires copilot-scope access
  • any previous granted copilot access (e.g. from another account) will get revoked - and with that copilot doesn't work anymore

My current solution:
I've downgraded PR plugin to version v0.74.1 and with that, the Plugin only needs permissions to PullRequests.
And my enterprise-managed account (with the Copilot license) is still able to stay logged in.

@SANSKARJAIN2
Copy link

same. extension just continuously prompts for login, and once I log in, there's another prompt. seems login prompts are stacking and an infinite loop is going on.

@Am0rfu5
Copy link

Am0rfu5 commented Mar 9, 2024

Version: 1.87.1
Commit: 1e790d77f81672c49be070e04474901747115651
Date: 2024-03-06T00:21:07.287Z
Electron: 27.3.2
ElectronBuildId: 26836302
Chromium: 118.0.5993.159
Node.js: 18.17.1
V8: 11.8.172.18-electron.0
OS: Linux x64 6.5.0-14-generic

Same isse wth Github PR v0.82.0

Reproduced issue exactly as stated above by @syffs

@Am0rfu5
Copy link

Am0rfu5 commented Mar 9, 2024

Spending 2 seconds reading the documentation fixed this for me. In my case I named the remote 'github' instead of 'origin' or 'upstream'. Just added that and it works fine.

Would add that having the Sign In fail makes sense BUT it isn't obvious what the issue is. Could add a note under that "Sign In" dialog to validate that the remote name matches, just for my fellow midwits who don't read the docs.

@alexr00
Copy link
Member

alexr00 commented Mar 11, 2024

This requires copilot-scope access

This extension does not require a copilot scope. You can see all the scopes we ask for here:

const SCOPES_OLDEST = ['read:user', 'user:email', 'repo'];
const SCOPES_OLD = ['read:user', 'user:email', 'repo', 'workflow'];
const SCOPES_WITH_ADDITIONAL = ['read:user', 'user:email', 'repo', 'workflow', 'project', 'read:org'];

I have a similar issue (and wanted to create an issue when i've seen this one 😅 ) where my enterprise-managed account (where the Copilot-license is handled) conflict with the PullRequest extension and my personal account which i'm using for normal operations.

@bavarianbidi, the problem that you encountered is that the GitHub Authentication extension doesn't support signing in with more than one GitHub account, though it did let you get into that state. If you sign out of one of the accounts you should be OK. @TylerLeonhardt FYI.

Github Pull Requests extension keep showing the same pane with "You have not yet signed in with GitHub", and clicking on Sign in does not do anything:

@syffs, can you please reproduce the issue then share the output from GitHub Pull Requests and GitHub Authentication?

Would add that having the Sign In fail makes sense BUT it isn't obvious what the issue is. Could add a note under that "Sign In" dialog to validate that the remote name matches, just for my fellow midwits who don't read the docs.

@Am0rfu5, you shouldn't see the "Sign In" button, but instead you should see a prompt to configure your remotes when you're signed in but we don't recognize any of your remotes:
image
If you see this again, can you please share the output from GitHub Pull Requests?

@alexr00 alexr00 added the info-needed Issue requires more information from poster label Mar 11, 2024
@TylerLeonhardt
Copy link
Member

Multiple GitHub account in VS Code is tracked here: microsoft/vscode#127967

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

6 participants