Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logic to replace tilde with home environment #524

Merged
merged 1 commit into from Mar 8, 2024

Conversation

MGasiewski
Copy link
Contributor

@MGasiewski MGasiewski commented Mar 6, 2024

Fixes #511

@MGasiewski
Copy link
Contributor Author

MGasiewski commented Mar 6, 2024 via email

@MGasiewski MGasiewski changed the title add logic to replace tilde with home environment Add logic to replace tilde with home environment. Fixes #511 Mar 6, 2024
@MGasiewski MGasiewski marked this pull request as ready for review March 6, 2024 21:12
@MGasiewski MGasiewski marked this pull request as draft March 6, 2024 21:24
@MGasiewski
Copy link
Contributor Author

MGasiewski commented Mar 6, 2024 via email

@karthiknadig
Copy link
Member

@MGasiewski Thanks for the PR. For the licensing you have to type it out in this format:
image

@karthiknadig karthiknadig changed the title Add logic to replace tilde with home environment. Fixes #511 Add logic to replace tilde with home environment Mar 6, 2024
@MGasiewski
Copy link
Contributor Author

MGasiewski commented Mar 6, 2024 via email

@MGasiewski MGasiewski marked this pull request as ready for review March 6, 2024 21:54
@MGasiewski
Copy link
Contributor Author

It's failing on linting files I did not change. Unclear to me how to handle this.

@karthiknadig
Copy link
Member

I will update the main branch with linting fixes.

@karthiknadig karthiknadig self-assigned this Mar 8, 2024
@karthiknadig karthiknadig self-requested a review March 8, 2024 16:56
@karthiknadig karthiknadig added the bug Issue identified by VS Code Team member as probable bug label Mar 8, 2024
@VSCodeTriageBot VSCodeTriageBot added this to the March 2024 milestone Mar 8, 2024
@karthiknadig karthiknadig enabled auto-merge (squash) March 8, 2024 21:28
@karthiknadig karthiknadig merged commit aafe440 into microsoft:main Mar 8, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent treatment of python.analysis.extraPaths between pylint and pylance
4 participants