Experiments should not block on telemetry.

microsoft · Apr 2, 2020 · 2b42457 · 2b42457
1 parent aa23403
commit 2b42457
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/news/2 Fixes/10008.md b/news/2 Fixes/10008.md
@@ -0,0 +1 @@
+Experiments no longer block on telemetry.
diff --git a/src/client/common/experiments.ts b/src/client/common/experiments.ts
@@ -9,7 +9,7 @@ import { inject, injectable, named, optional } from 'inversify';
 import { parse } from 'jsonc-parser';
 import * as path from 'path';
 import { IConfigurationService, IHttpClient } from '../common/types';
-import { isTelemetryDisabled, sendTelemetryEvent } from '../telemetry';
+import { sendTelemetryEvent } from '../telemetry';
 import { EventName } from '../telemetry/constants';
 import { IApplicationEnvironment, IWorkspaceService } from './application/types';
 import { EXTENSION_ROOT_DIR, STANDARD_OUTPUT_CHANNEL } from './constants';
@@ -116,7 +116,7 @@ export class ExperimentsManager implements IExperimentsManager {
 
     @swallowExceptions('Failed to activate experiments')
     public async activate(): Promise<void> {
-        if (this.activatedOnce || isTelemetryDisabled(this.workspaceService)) {
+        if (this.activatedOnce) {
             return;
         }
         this.activatedOnce = true;
@@ -336,4 +336,4 @@ export class ExperimentsManager implements IExperimentsManager {
         this._experimentsOptedInto = this._experimentsOptedInto.filter((exp) => exp !== '');
         this._experimentsOptedOutFrom = this._experimentsOptedOutFrom.filter((exp) => exp !== '');
     }
-}
+}