Skip to content

Commit

Permalink
Workaround test issue (#13930)
Browse files Browse the repository at this point in the history
* Try different version of VS code in release

* Change to make it use the actual variable

* Use a real version
  • Loading branch information
rchiodo committed Sep 15, 2020
1 parent 83b8b23 commit d4f3967
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
1 change: 1 addition & 0 deletions build/ci/templates/globals.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,4 @@ variables:
npm_config_cache: $(Pipeline.Workspace)/.npm
vmImageMacOS: 'macOS-10.15'
TS_NODE_FILES: true # Temporarily enabled to allow using types from vscode.proposed.d.ts from ts-node (for tests).
VSC_PYTHON_CI_TEST_VSC_CHANNEL: '1.48.0' # Enforce this until https://github.com/microsoft/vscode-test/issues/73 is fixed
4 changes: 1 addition & 3 deletions src/test/standardTest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,7 @@ const extensionDevelopmentPath = process.env.CODE_EXTENSIONS_PATH
? process.env.CODE_EXTENSIONS_PATH
: EXTENSION_ROOT_DIR_FOR_TESTS;

const channel = (process.env.VSC_PYTHON_CI_TEST_VSC_CHANNEL || '').toLowerCase().includes('insiders')
? 'insiders'
: 'stable';
const channel = process.env.VSC_PYTHON_CI_TEST_VSC_CHANNEL || 'stable';

function start() {
console.log('*'.repeat(100));
Expand Down

0 comments on commit d4f3967

Please sign in to comment.