Skip to content

Commit

Permalink
remove duplicates from test_ids array (#21347)
Browse files Browse the repository at this point in the history
this will partially remediate
#21339 in regards to
the duplicate IDs being run.
  • Loading branch information
eleanorjboyd committed May 31, 2023
1 parent f148139 commit e9a8dd5
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/client/testing/testController/workspaceTestAdapter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export class WorkspaceTestAdapter {

let rawTestExecData;
const testCaseNodes: TestItem[] = [];
const testCaseIds: string[] = [];
const testCaseIdsSet = new Set<string>();
try {
// first fetch all the individual test Items that we necessarily want
includes.forEach((t) => {
Expand All @@ -95,10 +95,10 @@ export class WorkspaceTestAdapter {
runInstance.started(node); // do the vscode ui test item start here before runtest
const runId = this.vsIdToRunId.get(node.id);
if (runId) {
testCaseIds.push(runId);
testCaseIdsSet.add(runId);
}
});

const testCaseIds = Array.from(testCaseIdsSet);
// ** execution factory only defined for new rewrite way
if (executionFactory !== undefined) {
rawTestExecData = await this.executionAdapter.runTests(
Expand Down

0 comments on commit e9a8dd5

Please sign in to comment.