Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor interpreter discovery #12020

Closed
kimadeline opened this issue May 27, 2020 · 2 comments
Closed

Refactor interpreter discovery #12020

kimadeline opened this issue May 27, 2020 · 2 comments
Assignees
Labels
area-environments Features relating to handling interpreter environments debt Covers everything internal: CI, testing, refactoring of the codebase, etc. meta Issue that is tracking an overall project

Comments

@kimadeline
Copy link

kimadeline commented May 27, 2020

Make it harder, better, faster, stronger in its own module.

@karthiknadig
Copy link
Member

Handle this case when refactoring: #8509

@raratiru
Copy link

raratiru commented Dec 19, 2020

I landed here because in my setup, python and pipenv executables are correctly recognized according to my settings.json:

{
   ...
    "python.pipenvPath": "/home/user/.local/bin/pipenv",
    "python.pythonPath": "${workspaceFolder}/.venv/bin/python"
}

However, I have to manually re-select the same (already recognized) interpreter Python 3.8.6 64-bit ("myenv": pipenv).

Otherwise, when vscode automatically asks to install pylint for example, the command issued will not be the expected:

pipenv install pylint --dev.

It will be:

/home/user/project/.venv/bin/python /home/user/.vscode/extensions/ms-python.python-2020.12.424452561/pythonFiles/pyvsc-run-isolated.py pip install -U pylint
$ uname -a
Linux House 5.4.0-0.bpo.4-amd64 #1 SMP Debian 5.4.19-1~bpo10+1 (2020-03-09) x86_64 GNU/Linux

$ code --version
1.52.1

kbd added a commit to kbd/setup that referenced this issue Feb 2, 2021
Just depend on setting it in each project.

Setting python.venvPath and/or python.venvFolders doesn't seem to work,
and vscode doesn't support Poetry environments natively yet.

The interpreter discovery in vscode is being refactored:
microsoft/vscode-python#12020

Revisit when that's done.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-environments Features relating to handling interpreter environments debt Covers everything internal: CI, testing, refactoring of the codebase, etc. meta Issue that is tracking an overall project
Projects
None yet
Development

No branches or pull requests

5 participants