Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly support file path casing #12328

Closed
luabud opened this issue Jun 12, 2020 · 2 comments
Closed

Properly support file path casing #12328

luabud opened this issue Jun 12, 2020 · 2 comments
Labels
area-internal Label for non-user facing issues feature-request Request for new features or functionality needs spike Label for issues that need investigation before they can be worked on.

Comments

@luabud
Copy link
Member

luabud commented Jun 12, 2020

From VS Code's 1.46 update:

https://code.visualstudio.com/updates/v1_46#_file-path-casing

File path casing

[...] the behavior of the openTextDocument function has changed. The function can now return a document with a URI with different casing than the URI that was passed in. This means extensions should use TextDocument#uri as the source of truth, not the URI that they request it with.
@luabud luabud added feature-request Request for new features or functionality triage-needed Needs assignment to the proper sub-team labels Jun 12, 2020
@kimadeline kimadeline added area-internal Label for non-user facing issues needs spike Label for issues that need investigation before they can be worked on. labels Jun 16, 2020
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Jun 16, 2020
@luabud
Copy link
Member Author

luabud commented Jun 16, 2020 •
edited
Loading

#2976

@karrtikr
Copy link

I've scanned through the extension and we use openTextDocument API as described.

@karrtikr karrtikr closed this as not planned Won't fix, can't repro, duplicate, stale Dec 21, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-internal Label for non-user facing issues feature-request Request for new features or functionality needs spike Label for issues that need investigation before they can be worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@karrtikr @luabud @kimadeline