Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stock launch.json "attach" configs should be using "connect" #12446

Closed
int19h opened this issue Jun 19, 2020 · 1 comment
Closed

Stock launch.json "attach" configs should be using "connect" #12446

int19h opened this issue Jun 19, 2020 · 1 comment
Assignees
@int19h
Labels
area-debugging feature-request Request for new features or functionality

Comments

@int19h
Copy link

int19h commented Jun 19, 2020

(instead of top-level "host" and "port"; see #10379 for details)
@int19h int19h added feature-request Request for new features or functionality triage-needed Needs assignment to the proper sub-team labels Jun 19, 2020
@int19h
Copy link
Author

int19h commented Jun 19, 2020

Need to decide if we are going to pick a default - and if so, whether it's "listen" or "connect" - or provide both versions.

@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Jun 22, 2020
@int19h int19h self-assigned this Jun 22, 2020
@int19h int19h changed the title Stock launch.json "attach" configs should be using "listen" or "connect" Stock launch.json "attach" configs should be using "connect" Jun 23, 2020
int19h added a commit to int19h/vscode-python that referenced this issue Jun 23, 2020
@int19h
Fix microsoft#12446: Stock launch.json "attach" configs should be usi…
2a0bfdf 
…ng "connect"

Change RemoteAttachDebugConfigurationProvider to generate configs with "connect".
@int19h int19h mentioned this issue Jun 23, 2020
Merged
10 tasks
int19h added a commit to int19h/vscode-python that referenced this issue Jun 23, 2020
@int19h
Fix microsoft#12446: Stock launch.json "attach" configs should be usi…
78349da 
…ng "connect"

Change RemoteAttachDebugConfigurationProvider to generate configs with "connect".
@int19h int19h closed this as completed in fb501ec Jun 25, 2020
@ghost ghost removed the needs PR label Jun 25, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@int19h int19h

Labels
area-debugging feature-request Request for new features or functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@int19h @karthiknadig