Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select interpreter is confusing when there're very few envs #19904

Open
jrieken opened this issue Sep 28, 2022 · 7 comments
Open

Select interpreter is confusing when there're very few envs #19904

jrieken opened this issue Sep 28, 2022 · 7 comments
Labels
area-environments Features relating to handling interpreter environments feature-request Request for new features or functionality needs proposal Need to make some design decisions

Comments

@jrieken
Copy link
Member

jrieken commented Sep 28, 2022

Testing #19884

  • have 1 conda and 1 venv env
  • run the select interpreter command
  • 😕 it's really hard to understand what the current env is
  • 😕 the recommended env is load because of the icon
  • there are many groups and separators which I guess it exceptional because I have very few envs?

Screenshot 2022-09-28 at 11 40 41

/cc @daviddossett again for quick pick guidelines

  • don't use placeholder for current selection
  • don't use title but use "Select Interpreter" as placeholder
  • use detail/description or icon for currently selected env
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Sep 28, 2022
@karthiknadig karthiknadig added bug Issue identified by VS Code Team member as probable bug area-environments Features relating to handling interpreter environments feature-request Request for new features or functionality and removed bug Issue identified by VS Code Team member as probable bug labels Sep 28, 2022
@daviddossett
Copy link

Can we simply show a selection for the selected interpreter like we do in other areas e.g. selected theme? Here's what I see when I use [cmd k + cmd t]:

CleanShot 2022-10-03 at 09 25 47@2x

@karrtikr
Copy link

karrtikr commented Oct 3, 2022

We do show a selection for the selected interpreter when the quickpick is opened.

@karrtikr
Copy link

😕 it's really hard to understand what the current env is

@jrieken We maintain the selection as @daviddossett suggested here #19904 (comment), do you suggest we add a detail property as well?

😕 the recommended env is load because of the icon

Do you suggest we remove the star icon given we already have a group for recommended?

there are many groups and separators which I guess it exceptional because I have very few envs?

Yes

don't use placeholder for current selection
don't use title but use "Select Interpreter" as placeholder

That seems fair, currently placeholder indicates the currently selected interpreter.

@luabud @daviddossett Would appreciate your opinion here as well 🙂

@karrtikr karrtikr changed the title Select interpreter is confusing Select interpreter is confusing when there're very few envs Nov 18, 2022
@karrtikr karrtikr removed their assignment Nov 18, 2022
@karrtikr karrtikr added needs proposal Need to make some design decisions and removed triage-needed Needs assignment to the proper sub-team labels Nov 18, 2022
@daviddossett
Copy link

Re: showing selected interpreter — could we do something lightweight like this?

CleanShot 2022-11-21 at 15 47 26@2x

FYI I summarized some quick pick guidance here: microsoft/vscode#158895 (comment)

@luabud
Copy link
Member

luabud commented Nov 23, 2022

@daviddossett is your suggestion to drop the separators altogether? Separators are really helpful when you have multiple environments on your machine, which is a pretty common scenario for folks who work on multiple Python projects. It turned into a feature request as soon as Jupyter started using it for their kernel picker (#17944).

We do highlight the currently selected interpreter by default, so I'm wondering if we can just use the "selection" as the marker of what is the currently selected interpreter (+ the info on the status bar?). Otherwise, I like David's suggestion of adding the "currently selected" text before the interpreter path.

For the placeholder, we have #20129) to replace what we have with "type to filter..." instead

@karrtikr
Copy link

karrtikr commented Dec 12, 2022

Sounds good. Turns out we have the refresh icon so we cannot remove the title in favor of placeholder which says "Select Interpreter", #20129 can cover that.

@daviddossett Do you have suggestion on how to highlight the recommended interpreter? Currently we have both a star icon and the recommended group.

@daviddossett
Copy link

is your suggestion to drop the separators altogether?

@luabud sorry for missing this. And no, I didn't mean to suggest that. I think I was just referring to this idea where we further indicate the current selection with this description/label:

CleanShot 2022-12-13 at 15 40 59@2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-environments Features relating to handling interpreter environments feature-request Request for new features or functionality needs proposal Need to make some design decisions
Projects
None yet
Development

No branches or pull requests

5 participants