Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop the "Sort Imports" menu option #20233

Closed
brettcannon opened this issue Nov 15, 2022 · 3 comments · Fixed by #22058
Closed

Drop the "Sort Imports" menu option #20233

brettcannon opened this issue Nov 15, 2022 · 3 comments · Fixed by #22058
Assignees
@ludizhan
Labels
feature-request Request for new features or functionality good first issue verification-needed Verification of issue is requested verified Verification succeeded
Milestone
September 2023

Comments

@brettcannon
Copy link
Member

It's redundant in the face of the code actions menu option. This probably also make the "sort imports" command redundant as well.
@brettcannon brettcannon added the feature-request Request for new features or functionality label Nov 15, 2022
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Nov 15, 2022
@karthiknadig karthiknadig removed the triage-needed Needs assignment to the proper sub-team label Jul 12, 2023
@karthiknadig karthiknadig removed their assignment Jul 12, 2023
@karthiknadig karthiknadig added the needs PR Ready to be worked on label Jul 12, 2023
@github-actions github-actions bot removed the ghc-osd label Sep 16, 2023
@luabud luabud added the ghc-osd label Sep 16, 2023
@luabud
Copy link
Member

luabud commented Sep 18, 2023

We are reserving this issue for Grace Hopper's Open Source Day, which will take place on September 22nd, 2023. If you're part of the event and would like to submit a contribution to this issue, please let us know, and we'll be happy to assign it to you.

For other community members who are not participating in the event, we appreciate your interest in contributing! We kindly request that you wait until after September 22nd to work on this issue. If no one from the event has been assigned to it by then, we'll gladly assign it to you. Thank you for your understanding and support!

@ludizhan
Copy link

@luabud can I take this issue? Thank you!

This was referenced Sep 22, 2023
Closed
Merged
karrtikr pushed a commit that referenced this issue Sep 22, 2023
@ludizhan
Remove sort imports from command palette and context menu (#22058)
dfc939b 
Fixes #20233
@karrtikr karrtikr added the verification-needed Verification of issue is requested label Sep 22, 2023
@github-actions github-actions bot removed the needs PR Ready to be worked on label Sep 22, 2023
@karrtikr karrtikr added this to the September 2023 milestone Sep 22, 2023
@karrtikr
Copy link

@ludizhan
Fix should be out in the pre-release version of the extension in a day, use the following to try it out:

image

@jrieken jrieken added the verified Verification succeeded label Sep 26, 2023
eleanorjboyd pushed a commit to eleanorjboyd/vscode-python that referenced this issue Oct 2, 2023
@ludizhan @eleanorjboyd
Remove sort imports from command palette and context menu (microsoft#…
5a20d3f 
…22058)

Fixes microsoft#20233
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ludizhan ludizhan

Labels
feature-request Request for new features or functionality good first issue verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
September 2023
6 participants
@brettcannon @jrieken @karthiknadig @karrtikr @luabud @ludizhan