Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike: Investigate using webworker for Python discovery #21755

Closed
karrtikr opened this issue Aug 4, 2023 · 5 comments
Closed

Spike: Investigate using webworker for Python discovery #21755

karrtikr opened this issue Aug 4, 2023 · 5 comments
Assignees
Labels
area-environments Features relating to handling interpreter environments feature-request Request for new features or functionality verified Verification succeeded

Comments

@karrtikr
Copy link

karrtikr commented Aug 4, 2023

#15813

@karrtikr karrtikr added feature-request Request for new features or functionality area-environments Features relating to handling interpreter environments needs spike Label for issues that need investigation before they can be worked on. labels Aug 4, 2023
@karrtikr karrtikr added this to the August 2023 milestone Aug 4, 2023
@karrtikr karrtikr self-assigned this Aug 4, 2023
@Frnchy1

This comment was marked as spam.

@karrtikr
Copy link
Author

karrtikr commented Sep 14, 2023

Spike

Discovery = locator + watcher + resolver

vscode module is not available to use in worker threads, so we have to refactor them out. APIs we currently use:

  • Locator requires workspace.workspaceFolders and workspace.onDidChangeWorkspaceFolders
  • Watcher requires workspace.createFileSystemWatcher, EventEmitter, RelativePattern
  • Uri itself
  • ...maybe more

Resolver & locator part are expensive, watcher can be outside. The issue right now is watcher is part of the locator, locator gives out existing environment locations and watcher returns whether there's an new env in those locations.

@karrtikr
Copy link
Author

Spawning conda or "REG" binary (windows registry) can block the main thread for a few seconds:
image

@karrtikr
Copy link
Author

karrtikr commented Sep 21, 2023

@karrtikr
Copy link
Author

karrtikr commented Oct 3, 2023

Spike results: #22146 (comment)

@karrtikr karrtikr closed this as completed Oct 3, 2023
@karrtikr karrtikr modified the milestones: October 2023, September 2023 Oct 3, 2023
@karrtikr karrtikr added the verified Verification succeeded label Oct 3, 2023
@github-actions github-actions bot removed the needs spike Label for issues that need investigation before they can be worked on. label Oct 3, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-environments Features relating to handling interpreter environments feature-request Request for new features or functionality verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants