Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also show name for conda environments created in the workspace #21770

Closed
DonJayamanne opened this issue Aug 6, 2023 · 12 comments · Fixed by #22701
Closed

Also show name for conda environments created in the workspace #21770

DonJayamanne opened this issue Aug 6, 2023 · 12 comments · Fixed by #22701
Assignees
Labels
area-environments Features relating to handling interpreter environments feature-request Request for new features or functionality good first issue verification-needed Verification of issue is requested verified Verification succeeded

Comments

@DonJayamanne
Copy link

I have two workspace conda environments namely .conda and .condaTesting as well as a number of virtual environments named .venv, etc..

As you can see from the image, the names of the workspace level conda enviornments are wrong.
As a result its very confusing to tell what conda env has been selected.
Screenshot 2023-08-06 at 19 20 48

@DonJayamanne DonJayamanne added the bug Issue identified by VS Code Team member as probable bug label Aug 6, 2023
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Aug 6, 2023
@myabanky

This comment was marked as resolved.

@DonJayamanne

This comment was marked as resolved.

@karrtikr karrtikr changed the title Incorrect display name for workspace conda environment, always displays the name as conda Also show name for conda environments created in the workspace Aug 9, 2023
@karrtikr karrtikr added good first issue debt Covers everything internal: CI, testing, refactoring of the codebase, etc. area-environments Features relating to handling interpreter environments needs PR Ready to be worked on and removed bug Issue identified by VS Code Team member as probable bug triage-needed Needs assignment to the proper sub-team labels Aug 9, 2023
@karrtikr karrtikr removed their assignment Aug 9, 2023
@karrtikr
Copy link

karrtikr commented Aug 9, 2023

At least when displaying it, we can show the name. Even though while activating or using the environments, these have no names.

Marking as a good first issue, code to be modified here:

function buildEnvDisplayString(env: PythonEnvInfo, getAllDetails = false): string {

if env.searchLocation exists and it is a conda environment, create display name using env name.

@karthiknadig karthiknadig added feature-request Request for new features or functionality and removed debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Sep 5, 2023
@luabud luabud added the ghc-osd label Sep 8, 2023
@github-actions github-actions bot removed the ghc-osd label Sep 16, 2023
@luabud luabud added the ghc-osd label Sep 16, 2023
@luabud
Copy link
Member

luabud commented Sep 18, 2023

We are reserving this issue for Grace Hopper's Open Source Day, which will take place on September 22nd, 2023. If you're part of the event and would like to submit a contribution to this issue, please let us know, and we'll be happy to assign it to you.

For other community members who are not participating in the event, we appreciate your interest in contributing! We kindly request that you wait until after September 22nd to work on this issue. If no one from the event has been assigned to it by then, we'll gladly assign it to you. Thank you for your understanding and support!

@CosetteX
Copy link

Hi @luabud Can I take this issue?

@karrtikr
Copy link

@CosetteX Yep go ahead.

@luabud
Copy link
Member

luabud commented Oct 20, 2023

Hi @CosetteX, since it's been one month since OSD I'm removing you as an assignee. You can still feel free to submit a PR to this issue if you'd like, but we're going to leave it open for other contributors too.

@luabud luabud removed the ghc-osd label Oct 20, 2023
@PopoDev
Copy link

PopoDev commented Dec 27, 2023

Hi @karrtikr, I'd like to give it a try!

If I understood correctly conda environments don't have an env.name. Can we create the display name using the basename of env.location ?

@github-actions github-actions bot removed the needs PR Ready to be worked on label Jan 19, 2024
@karrtikr
Copy link

Fix should be out in the pre-release version of the extension in a day, use the following to try it out:

image

@karrtikr karrtikr added this to the December / January 2024 milestone Jan 19, 2024
@karrtikr karrtikr added the verification-needed Verification of issue is requested label Jan 19, 2024
@PopoDev
Copy link

PopoDev commented Jan 20, 2024

The fix seems to work as expected. It shows the names of the workspace level conda environments, e.g .conda, .condaTesting and .condaWorkspace.

validate-show-conda-env-names

@PopoDev
Copy link

PopoDev commented Jan 20, 2024

Also the new Create Environment in Select Interpreter looks neat !

@jrieken jrieken added the verified Verification succeeded label Jan 25, 2024
@jrieken
Copy link
Member

jrieken commented Jan 25, 2024

Adding verified based on #21770 (comment)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-environments Features relating to handling interpreter environments feature-request Request for new features or functionality good first issue verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants