Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subprocess exit error handling on discovery #21999

Closed
eleanorjboyd opened this issue Sep 15, 2023 · 1 comment · Fixed by #22026
Closed

Add subprocess exit error handling on discovery #21999

eleanorjboyd opened this issue Sep 15, 2023 · 1 comment · Fixed by #22026
Assignees
Labels
area-testing bug Issue identified by VS Code Team member as probable bug verified Verification succeeded

Comments

@eleanorjboyd
Copy link
Member

Add error processing so when the discovery subprocess dies there is still a payload crafted and sends that gives information on the failure. See similar subprocess exit handling for execution.

@eleanorjboyd eleanorjboyd added bug Issue identified by VS Code Team member as probable bug area-testing needs PR Ready to be worked on labels Sep 15, 2023
@eleanorjboyd eleanorjboyd self-assigned this Sep 15, 2023
@eleanorjboyd
Copy link
Member Author

The following is code that should error and display something to the user that is easily findable / understandable:

# Copyright (c) Microsoft Corporation. All rights reserved.
# Licensed under the MIT License.

import unittest
import ctypes

ctypes.string_at(0)  # Dereference a NULL pointer


class TestSegmentationFault(unittest.TestCase):
    def test_segfault(self):
        assert True


if __name__ == "__main__":
    unittest.main()

@github-actions github-actions bot removed the needs PR Ready to be worked on label Sep 19, 2023
@eleanorjboyd eleanorjboyd added this to the September 2023 milestone Sep 25, 2023
@DonJayamanne DonJayamanne added the verified Verification succeeded label Sep 28, 2023
eleanorjboyd added a commit to eleanorjboyd/vscode-python that referenced this issue Oct 2, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-testing bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants