Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The test error zone is not very useful #22312

Open
aeschli opened this issue Oct 24, 2023 · 3 comments
Open

The test error zone is not very useful #22312

aeschli opened this issue Oct 24, 2023 · 3 comments
Assignees
Labels
area-testing needs PR Ready to be worked on

Comments

@aeschli
Copy link

aeschli commented Oct 24, 2023

Testing #21861

When selecting a failed test item, the editor gets focus and the test failure is shown in an editor zone
image

  • the error points to the definition of the test. It would be more useful if it points to the assertion that failed. Also note that the arrow of the overlay is pointing to whitespace
  • the editor overlay is very large. Is seems to cover the rest of the editor. The larger the editor the larger the zone. It would be nice if it's only as big as the information it shows
  • the editor zone repeats the information already shown in the title. test_subtests.NumbersTest.test_even (i=7305) is shown 3 times in the zone, plus as ghost text in the editor
  • the stacktrace is not useful. It doesn't have links to navigate to the locations. But I doubt I would want to navigate to the locations as they point in to the python unittest test runner
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Oct 24, 2023
@eleanorjboyd
Copy link
Member

The second bullet is something @connor4312 and I had been discussing. The rest I will look into! Thanks

@connor4312
Copy link
Member

the editor overlay is very large. Is seems to cover the rest of the editor. The larger the editor the larger the zone. It would be nice if it's only as big as the information it shows

The widget defaults to approximately the number of lines in the error message, unless the widget was previously resized by the user in this session. In that case, the user's size is taken. I'm guessing the latter case is kicking in here.

https://github.com/microsoft/vscode/blob/cd6dc14f2e650e2e97f72c3b01353150e6aa963b/src/vs/workbench/contrib/testing/browser/testingOutputPeek.ts#L1012

@eleanorjboyd eleanorjboyd added needs PR Ready to be worked on area-testing and removed triage-needed Needs assignment to the proper sub-team labels Oct 26, 2023
@aeschli
Copy link
Author

aeschli commented Oct 27, 2023

I can't reproduce the issue on my home machine. What I see here is what you describe in #22312 (comment). One I manually change the height it sticks to that height.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-testing needs PR Ready to be worked on
Projects
None yet
Development

No branches or pull requests

3 participants