Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pytest 8 introduced breaking changes: make fixes to align with Pytest 8 #22798

Closed
eleanorjboyd opened this issue Jan 29, 2024 · 1 comment · Fixed by #22799
Closed

Pytest 8 introduced breaking changes: make fixes to align with Pytest 8 #22798

eleanorjboyd opened this issue Jan 29, 2024 · 1 comment · Fixed by #22799
Assignees
Labels
area-testing bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verification-needed Verification of issue is requested

Comments

@eleanorjboyd
Copy link
Member

changelog for pytest 8: https://docs.pytest.org/en/latest/changelog.html
tests fail for repo because session.name of this change:
[session.name](https://docs.pytest.org/en/latest/reference/reference.html#pytest.Session.name) is now ""; previously it was the rootdir directory name. This matches [session.nodeid](https://docs.pytest.org/en/latest/reference/reference.html#pytest.nodes.Node.nodeid) which has always been "".

@eleanorjboyd eleanorjboyd added the feature-request Request for new features or functionality label Jan 29, 2024
@eleanorjboyd eleanorjboyd self-assigned this Jan 29, 2024
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Jan 29, 2024
@eleanorjboyd eleanorjboyd added bug Issue identified by VS Code Team member as probable bug area-testing and removed feature-request Request for new features or functionality triage-needed Needs assignment to the proper sub-team labels Jan 29, 2024
@eleanorjboyd
Copy link
Member Author

other changes which caused breakage in our tests (not in the user experience tho)

#8976: Running pytest pkg/init.py now collects the pkg/init.py file (module) only. Previously, it collected the entire pkg package, including other test files in the directory, but excluding tests in the init.py file itself (unless python_files was changed to allow init.py file).

and

#7777: Files and directories are now collected in alphabetical order jointly, unless changed by a plugin. Previously, files were collected before directories. See below for an example.

eleanorjboyd added a commit that referenced this issue Jan 29, 2024
@karthiknadig karthiknadig added verification-needed Verification of issue is requested candidate Issue identified as probable candidate for fixing in the next release labels Jan 29, 2024
anthonykim1 pushed a commit to anthonykim1/vscode-python that referenced this issue Jan 30, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-testing bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verification-needed Verification of issue is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants