Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use VS Code FS API #6911

Closed
DonJayamanne opened this issue Aug 8, 2019 · 3 comments
Closed

Use VS Code FS API #6911

DonJayamanne opened this issue Aug 8, 2019 · 3 comments
Assignees
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc. important Issue identified as high-priority

Comments

@DonJayamanne
Copy link

DonJayamanne commented Aug 8, 2019

Easy change and we should do this.
https://code.visualstudio.com/updates/v1_37#_vscodeworkspacefs

To validate: use the extension and verify that nothing breaks. :)

@DonJayamanne DonJayamanne added the triage-needed Needs assignment to the proper sub-team label Aug 8, 2019
@brettcannon brettcannon added important Issue identified as high-priority needs PR labels Aug 12, 2019
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Aug 12, 2019
@brettcannon brettcannon added feature-* debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Aug 12, 2019
@DonJayamanne DonJayamanne added this to the 2019 - August Sprint 16 milestone Aug 14, 2019
@karrtikr
Copy link

karrtikr commented Aug 28, 2019

Try to use the vscode.workspace.fs API instead of fs and fs-extra wherever we can.

For the things that we can't do with the API, make a list of those things and open issues in vscode.

@ericsnowcurrently
Copy link
Member

ericsnowcurrently commented Nov 11, 2019

@ericsnowcurrently
Copy link
Member

Any workarounds or missing functionality is covered in #8533.

ericsnowcurrently added a commit that referenced this issue Nov 26, 2019
…7915)

(for #6911)

This is a precursor to the actual fix. It ensures that we really do use the new FS API everywhere.
ericsnowcurrently added a commit that referenced this issue Nov 26, 2019
(for #6911)

There are still workarounds that need to be resolved and other gaps (see #8533), but this is a solid start.
@ghost ghost removed the needs PR label Nov 26, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc. important Issue identified as high-priority
Projects
None yet
Development

No branches or pull requests

6 participants