Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike - Creation and activation of a new terminal when switching environments #8005

Closed
2 tasks done
luabud opened this issue Oct 15, 2019 · 3 comments
Closed
2 tasks done
Assignees
Labels
area-terminal feature-request Request for new features or functionality

Comments

@luabud
Copy link
Member

luabud commented Oct 15, 2019

  • Investigate if the extension can know if there's a terminal open
  • Investigate if it's possible to create a new terminal without displaying it
@luabud luabud added feature-request Request for new features or functionality needs PR area-terminal labels Oct 15, 2019
@luabud luabud changed the title Spike - creation of a new terminal Spike - creation and activation of a new terminal when switching environments Oct 15, 2019
@luabud luabud changed the title Spike - creation and activation of a new terminal when switching environments Spike - Creation and activation of a new terminal when switching environments Oct 15, 2019
@luabud luabud added important Issue identified as high-priority unplanned labels Oct 15, 2019
@luabud luabud added this to the 2019 October Sprint 2 milestone Oct 15, 2019
@luabud luabud removed the important Issue identified as high-priority label Oct 15, 2019
@brettcannon
Copy link
Member

There is an API to get a list of all terminals as well as the current/last active terminal, but there's no way to know from the Terminal object itself or anything else if the terminal is visible (there is an API to make one visible, though).

The TerminalOptions object that can be used to configure a new terminal has a hideFromUser which seems to hide the terminal from the user, but the docs don't clearly state if that is just for visibility or if it means it won't even be listed in the panel drop-down for terminals.

@karrtikr
Copy link

karrtikr commented Nov 12, 2019

As @brettcannon stated, there is currently no way to know if a particular terminal is currently visible or not.
Correction: Actually window.activeTerminal carries the last visible terminal. So we can know if a terminal is visible or not.

The TerminalOptions object that can be used to configure a new terminal has a hideFromUser which seems to hide the terminal from the user, but the that also hides the terminal from list in the panel drop-down for terminals.

@luabud
Copy link
Member Author

luabud commented Nov 13, 2019

Reviewed 👍 thanks Kartik!

@luabud luabud closed this as completed Nov 13, 2019
@ghost ghost removed the needs PR label Nov 13, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-terminal feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

5 participants